Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Estimated bandwidth savings in NTP #8845

Closed
anthonypkeane opened this issue Mar 24, 2020 · 1 comment · Fixed by brave/brave-core#5163
Closed

[Android] Estimated bandwidth savings in NTP #8845

anthonypkeane opened this issue Mar 24, 2020 · 1 comment · Fixed by brave/brave-core#5163
Assignees
@samartnik
Labels
feature/new-tab feature-request OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include
Projects
Android Core 1.9
Milestone
Android 1.9.x Rel...

Comments

@anthonypkeane
Copy link

Description

Please replace HTTPS with Data Saved on Android

@AndriusA has created the code for estimating data saved

For design see: #8256 (comment)
For implementation see: #7783
@anthonypkeane anthonypkeane added QA/Yes feature-request OS/Android Fixes related to Android browser functionality labels Mar 24, 2020
@anthonypkeane anthonypkeane added this to the 1.7.x - Beta milestone Mar 24, 2020
@anthonypkeane anthonypkeane added this to Backlog in Android General via automation Mar 25, 2020
@samartnik samartnik self-assigned this Apr 3, 2020
@samartnik samartnik mentioned this issue Apr 6, 2020
Merged
32 tasks
Android General automation moved this from Backlog to Done/Closed Apr 6, 2020
@samartnik samartnik mentioned this issue Apr 22, 2020
Closed
@SergeyZhukovsky SergeyZhukovsky added this to Backlog in Android Core 1.9 via automation May 13, 2020
@SergeyZhukovsky SergeyZhukovsky removed this from Done/Closed in Android General May 13, 2020
@SergeyZhukovsky SergeyZhukovsky moved this from Backlog to Done in Android Core 1.9 May 13, 2020
@srirambv srirambv mentioned this issue May 22, 2020
Closed
This was referenced May 22, 2020
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 22, 2020 •
edited by btlechowski
Loading

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm.apk 1.9.74
Screenshot_2020-05-22-13-33-55

Verification passed on Asus Zenfone (x86) with Android 6 running BraveModernx86.apk 1.9.74

Clean install scenario - confirmed Data Saved stat and other stats populate:
clean install - android

Upgrade scenario - populated stats on 1.8.x prior to upgrade:
upgrade 18x before

Confirmed after upgrade to 1.9.x - stats are populated and new stat appears:
upgrade - 19x after

Verification passed on BraveModernarm v1.9.74 on Samsung Galaxy Tab S5e (Android 9.0)

Verified clean install and upgrade scenarios

Logged #9915
Screenshot_20200523-041125_Brave

@btlechowski btlechowski mentioned this issue May 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
feature/new-tab feature-request OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include
Projects
No open projects
Android Core 1.9
  
Done
Milestone
Android 1.9.x Release
Development

Successfully merging a pull request may close this issue.

Added data saved stat on NTP brave/brave-core
7 participants
@anthonypkeane @SergeyZhukovsky @srirambv @LaurenWags @samartnik @btlechowski @GeetaSarvadnya