Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] URL is shown behind tab count on private tab when bottom toolbar is disabled #9040

Closed
srirambv opened this issue Apr 6, 2020 · 3 comments · Fixed by brave/brave-core#5412
Closed

[Android] URL is shown behind tab count on private tab when bottom toolbar is disabled #9040

srirambv opened this issue Apr 6, 2020 · 3 comments · Fixed by brave/brave-core#5412
Assignees
@samartnik
Labels
android-phone-specific feature/private-browsing OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include
Projects
Android General
Milestone
Android 1.8.x Rel...

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 6, 2020

Description

URL is shown behind tab count on private tab when bottom toolbar is disabled

Steps to reproduce

  1. Disable bottom tool bar
  2. Open a long URL in a private tab
  3. Tab count is shown inside URL bar making it transparent and looks very clumsy

Actual result

image

Expected result

Not what is in screenshot

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? Yes
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

10

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv added this to Backlog in Android General via automation Apr 6, 2020
@srirambv srirambv mentioned this issue Apr 13, 2020
Closed
@srirambv
Copy link
Contributor Author

+1 from @derekantrican via #9145

@AlexeyBarabash
Copy link
Contributor

I also was able to see it.

@samartnik samartnik self-assigned this Apr 28, 2020
@samartnik samartnik mentioned this issue Apr 28, 2020
Merged
32 tasks
Android General automation moved this from Backlog to Done/Closed Apr 29, 2020
@samartnik samartnik added this to the 1.10.x - Nightly milestone Apr 29, 2020
This was referenced May 4, 2020
Merged
Merged
This was referenced May 6, 2020
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 6, 2020 •
edited by LaurenWags

  • Verification passed on Samsung Galaxy J5 version 5.1.1 running BraveModernarm.apk 1.8.93
    image

  • Verification passed on BraveModernarm v1.8.93 on Samsung Galaxy Tab S5e (Android 9.0)

  • Verification passed on Asus Zenfone (x86) with Android 6 running BraveModernx86.apk 1.8.93

@kjozwiak kjozwiak mentioned this issue May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
android-phone-specific feature/private-browsing OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Milestone
Android 1.8.x Release
Development

Successfully merging a pull request may close this issue.

Fixed top toolbar with disabled bottom toolbar and no rewards icon brave/brave-core
7 participants
@kjozwiak @srirambv @AlexeyBarabash @LaurenWags @samartnik @btlechowski @GeetaSarvadnya