Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add widget stack transition #9248

Closed
rebron opened this issue Apr 15, 2020 · 3 comments
Closed

add widget stack transition #9248

rebron opened this issue Apr 15, 2020 · 3 comments
Labels
closed/duplicate Issue has already been reported feature/widgets priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 15, 2020

Description

When selecting a widget in the widget stack, there should be a transition animation to smooth out the selection, otherwise it's jarring.

Using the spaceindown effect.
example: https://www.minimamente.com/project/magic/

Steps to Reproduce

  1. Go to the New Tab page.
  2. Select widget in the background, either Brave Rewards or Binance to move it to the front.
  3. Notice that the selection happened abruptly.

Expected result:

Smoother transition when making a widget selection.

Reproduces how often:

Easily.

Brave version (brave://version info)

Brave 1.9.21 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS macOS Version 10.15.5 (Build 19F53f)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron
Copy link
Collaborator Author

rebron commented Apr 15, 2020

cc: @ryanml @karenkliu

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 17, 2020
@ryanml
Copy link
Contributor

ryanml commented Oct 6, 2020

Closing as a dupe of #8856

@ryanml ryanml closed this as completed Oct 6, 2020
@bbondy
Copy link
Member

bbondy commented Oct 13, 2020

Please add closed/duplicate label so the issue will be ignored.
QA/yes isn't needed, but also won't be looked at so not a big deal on that.

@ryanml ryanml added release-notes/exclude closed/duplicate Issue has already been reported labels Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/widgets priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants