Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave suggested sites for crypto wallets #9302

Closed
bbondy opened this issue Apr 17, 2020 · 3 comments · Fixed by brave/brave-core#5282
Closed

Brave suggested sites for crypto wallets #9302

bbondy opened this issue Apr 17, 2020 · 3 comments · Fixed by brave/brave-core#5282

Comments

@bbondy
Copy link
Member

bbondy commented Apr 17, 2020

Similar to top site suggestions, we'd like to add Crypto Widgets and Binance related suggestions based on what a user types in the URL bar. This is mostly an experiment to see if it's useful. It could be expanded in the future to involve BAT or even be used if the user has Brave ads turned on.

@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Apr 17, 2020
@bbondy bbondy self-assigned this Apr 17, 2020
@bbondy bbondy changed the title Placeholder - Brave suggested sites for crypto wallets Brave suggested sites for crypto wallets Apr 18, 2020
@bbondy bbondy added this to the 1.9.x - Nightly milestone Apr 20, 2020
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.9.61 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Linux
  • Verified typing binance shows two Brave suggested sites for Binance

Screen Shot 2020-05-11 at 12 28 21 PM

  • Verified typing binance.c only shows Brave suggested binance.com page

Screen Shot 2020-05-11 at 12 28 25 PM

  • Verified typing binance.u only shows Brave suggested binance.us page

Screen Shot 2020-05-11 at 12 28 28 PM

  • Verified disabling Brave suggested sites stops showing the links in URL bar while typing

Screen Shot 2020-05-11 at 12 31 46 PM

  • Verified if a page is visited via the suggested link and disabling Brave suggested sitesstill shos the visited page in suggestion. Stops showing after clearing browser data

Screen Shot 2020-05-11 at 12 28 03 PM

  • Verified Brave Suggested sites shows up when typing BTC / ETH / LTC / BNB

Screen Shot 2020-05-11 at 12 28 33 PM

Screen Shot 2020-05-11 at 12 28 37 PM

Screen Shot 2020-05-11 at 12 28 42 PM

  • Verified Brave Suggested sites shows up when typing Bitcoin/Ethereum/Lite`

Screen Shot 2020-05-11 at 12 29 08 PM

Screen Shot 2020-05-11 at 12 28 48 PM

  • Verified disabling/enabling Brave Suggested sites work without having to restart the browser

  • Verified typing ledger shows Brave suggested site for shop.ledger.com

Screen Shot 2020-05-11 at 12 34 12 PM

  • Verified typing trezor shows Brave suggested site for shop.trezor.io

Screen Shot 2020-05-11 at 12 34 17 PM

  • Verified typing coin or coinbase

  • Verified all suggested landing pages load correctly

  • Verified Brave suggested sites are low priority compared to other suggestions

Screen Shot 2020-05-11 at 12 28 03 PM

@srirambv
Copy link
Contributor

srirambv commented May 11, 2020

Verification passed on

Brave 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified typing binance shows two Brave suggested sites for Binance

Screen Shot 2020-05-11 at 1 33 56 PM

  • Verified typing binance.c only shows Brave suggested binance.com page

Screen Shot 2020-05-11 at 1 34 36 PM

  • Verified typing binance.u only shows Brave suggested binance.us page

Screen Shot 2020-05-11 at 1 34 34 PM

  • Verified disabling Brave suggested sites stops showing the links in URL bar while typing

  • Verified if a page is visited via the suggested link and disabling Brave suggested sitesstill shos the visited page in suggestion. Stops showing after clearing browser data

Screen Shot 2020-05-11 at 1 36 24 PM

  • Verified Brave Suggested sites shows up when typing BTC / ETH / LTC / BNB

Screen Shot 2020-05-11 at 1 33 15 PM

Screen Shot 2020-05-11 at 1 33 20 PM

Screen Shot 2020-05-11 at 1 33 23 PM

Screen Shot 2020-05-11 at 1 33 26 PM

  • Verified Brave Suggested sites shows up when typing Bitcoin/Ethereum/Lite`

  • Verified disabling/enabling Brave Suggested sites work without having to restart the browser

  • Verified typing ledger shows Brave suggested site for shop.ledger.com

Screen Shot 2020-05-11 at 1 33 31 PM

  • Verified typing trezor shows Brave suggested site for shop.trezor.io

Screen Shot 2020-05-11 at 1 33 36 PM

  • Verified typing coin or coinbase shows Brave suggested site in URL

Screen Shot 2020-05-11 at 1 33 42 PM

Screen Shot 2020-05-11 at 1 33 48 PM

@srirambv
Copy link
Contributor

srirambv commented May 11, 2020

Verification passed on

Brave 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Windows 10 OS Version 1809 (Build 17763.1158)
  • Verified typing binance shows two Brave suggested sites for Binance

Screen Shot 2020-05-11 at 3 52 48 PM

  • Verified typing binance.c only shows Brave suggested binance.com page

Screen Shot 2020-05-11 at 3 52 51 PM

- Verified typing `binance.u` only shows Brave suggested binance.us page

Screen Shot 2020-05-11 at 3 52 53 PM

  • Verified disabling Brave suggested sites stops showing the links in URL bar while typing

  • Verified if a page is visited via the suggested link and disabling Brave suggested sitesstill shows the visited page in suggestion. Stops showing after clearing browser data

Screen Shot 2020-05-11 at 3 54 08 PM

  • Verified Brave Suggested sites shows up when typing BTC / ETH / LTC / BNB

Screen Shot 2020-05-11 at 1 36 24 PM

Screen Shot 2020-05-11 at 3 52 24 PM

Screen Shot 2020-05-11 at 3 52 28 PM

Screen Shot 2020-05-11 at 3 52 33 PM

  • Verified Brave Suggested sites shows up when typing Bitcoin/Ethereum/Lite`

Screen Shot 2020-05-11 at 3 52 59 PM

Screen Shot 2020-05-11 at 3 53 04 PM

Screen Shot 2020-05-11 at 3 53 08 PM

Screen Shot 2020-05-11 at 3 53 14 PM

  • Verified disabling/enabling Brave Suggested sites work without having to restart the browser

  • Verified typing ledger shows Brave suggested site for shop.ledger.com

Screen Shot 2020-05-11 at 3 53 40 PM

  • Verified typing trezor shows Brave suggested site for shop.trezor.io

Screen Shot 2020-05-11 at 3 53 45 PM

  • Verified typing coin or coinbase shows Brave suggested site for Coinbase

Screen Shot 2020-05-11 at 3 53 20 PM

Screen Shot 2020-05-11 at 3 53 29 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment