Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add support for Chromecast #4631

Closed
wants to merge 1 commit into from
Closed

Re-add support for Chromecast #4631

wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 28, 2019

Fixes #209

Dependencies

Submitter Checklist:

Test Plan:

  1. Have a Chrome cast device plugged in and powered on
  2. Launch browser
  3. Click cast... menu from app menu
  4. Check available device list is visible in dialog

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton requested a review from jumde May 28, 2019 23:16
@bsclifton bsclifton self-assigned this May 28, 2019
@bsclifton bsclifton added this to the 0.67.x - Nightly milestone May 28, 2019
@jumde jumde requested review from jumde and diracdeltas May 28, 2019 23:17
lib/whitelistedUrlPrefixes.js Outdated Show resolved Hide resolved
lib/whitelistedUrlPrefixes.js Outdated Show resolved Hide resolved
@bsclifton bsclifton force-pushed the readd-chromecast branch 2 times, most recently from e41144c to efdc1fe Compare May 29, 2019 05:21
diracdeltas
diracdeltas previously approved these changes May 29, 2019
@bsclifton bsclifton changed the title WIP: Re-add support for Chromecast Re-add support for Chromecast Jun 5, 2019
@brave-builds brave-builds force-pushed the readd-chromecast branch 2 times, most recently from 759fb18 to d7ac5a9 Compare June 19, 2019 00:32
@bsclifton bsclifton removed the blocked label Jun 19, 2019
'https://publishers-staging-distro.basicattentiontoken.org/'
'https://publishers-staging-distro.basicattentiontoken.org/',
'https://extensionupdater.brave.com/',
'https://clients2.google.com/' // allowed because it 307's to https://extensionupdater.brave.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we be more specific with this prefix based on brave/brave-core#2493 (comment)?

for instance https://clients2.google.com/service/update2/crx

@mihaiplesa
Copy link
Collaborator

mihaiplesa commented Jun 24, 2019

@jumde jumde force-pushed the readd-chromecast branch 2 times, most recently from fed6e3a to 6602e85 Compare June 25, 2019 21:53
@bsclifton bsclifton modified the milestones: 0.67.x - Beta, 0.68.x - Dev Jun 27, 2019
@jumde jumde force-pushed the readd-chromecast branch 2 times, most recently from 091d6de to 89aab42 Compare July 3, 2019 17:42
@bsclifton
Copy link
Member Author

CLOSING - this is no longer needed 😄

@bsclifton bsclifton closed this Jul 23, 2019
@bsclifton bsclifton deleted the readd-chromecast branch July 23, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Chromecast support
4 participants