Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete .babelrc #636

Merged
merged 1 commit into from
Jul 24, 2018
Merged

delete .babelrc #636

merged 1 commit into from
Jul 24, 2018

Conversation

AlexeyBarabash
Copy link
Contributor

move .babelrc from brave-browser/.babelrc to brave-browser/src/brave/.babelrc because babel expects to find own modules like node_modules/babel-xxxxxx in a folder near .babelrc file. node_modules/babel-core/lib/transformation/file/options/build-config-chain.js .

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

move .babelrc from brave-browser to brave-core
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants