Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 78.0.3904.97 to Chromium 78.0.3904.108 (1.2.x) #7010

Merged
merged 2 commits into from Nov 20, 2019

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Nov 19, 2019

Fixes #6987
Related PR: brave/brave-core#4021

Uplift from #6990

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade from Chromium 78.0.3904.97 to Chromium 78.0.3904.108
@mkarolin mkarolin added this to the 1.2.x - Dev milestone Nov 19, 2019
@mkarolin mkarolin self-assigned this Nov 19, 2019
@mkarolin mkarolin marked this pull request as ready for review November 19, 2019 16:12
@bsclifton
Copy link
Member

Linux still running, Windows ran into a weird linker error:
https://ci.brave.com/job/brave-browser-build-pr/job/PR-7010/3/execution/node/368/log/

13:38:35  FAILED: chrome.dll chrome.dll.lib chrome.dll.pdb 
13:38:35  ninja -t msvc -e environment.x64 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL /OUT:./chrome.dll /PDB:./chrome.dll.pdb @./chrome.dll.rsp
13:38:35  lld-link: error: undefined symbol: public: void __cdecl ManagePasswordsState::OnPasswordAutofilled(class std::__1::map<class std::__1::basic_string<wchar_t, struct std::__1::char_traits<wchar_t>, class std::__1::allocator<wchar_t>>, struct autofill::PasswordForm const *, struct std::__1::less<class std::__1::basic_string<wchar_t, struct std::__1::char_traits<wchar_t>, class std::__1::allocator<wchar_t>>>, class std::__1::allocator<struct std::__1::pair<class std::__1::basic_string<wchar_t, struct std::__1::char_traits<wchar_t>, class std::__1::allocator<wchar_t>> const, struct autofill::PasswordForm const *>>> const &, class GURL const &, class std::__1::vector<struct autofill::PasswordForm const *, class std::__1::allocator<struct autofill::PasswordForm const *>> const *)
13:38:35  >>> referenced by ../../chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
13:38:35  >>>               ui.lib(manage_passwords_ui_controller.obj)

@bsclifton bsclifton requested review from bsclifton and a team and removed request for bsclifton November 19, 2019 22:14
@bsclifton
Copy link
Member

Restarting for Windows...

@mkarolin
Copy link
Contributor Author

Windows passed on CI retry.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 83bd7b8 into 1.2.x Nov 20, 2019
@bsclifton bsclifton deleted the 78.0.3904.108-1.2.x branch November 20, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants