Refactor BraveAds FilterConversions

brave · Dec 28, 2021 · 7cc5046 · 7cc5046
1 parent 1b86117
commit 7cc5046
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/vendor/bat-native-ads/src/bat/ads/internal/conversions/conversions.cc b/vendor/bat-native-ads/src/bat/ads/internal/conversions/conversions.cc
@@ -327,26 +327,25 @@ void Conversions::Convert(
 ConversionList Conversions::FilterConversions(
     const std::vector<std::string>& redirect_chain,
     const ConversionList& conversions) {
-  ConversionList filtered_conversions = conversions;
+  ConversionList filtered_conversions;
 
-  const auto iter = std::remove_if(
-      filtered_conversions.begin(), filtered_conversions.end(),
+  std::copy_if(
+      conversions.cbegin(), conversions.cend(),
+      std::back_inserter(filtered_conversions),
       [&redirect_chain](const ConversionInfo& conversion) {
         const auto iter = std::find_if(
             redirect_chain.begin(), redirect_chain.end(),
             [&conversion](const std::string& url) {
               return DoesUrlMatchPattern(url, conversion.url_pattern);
             });
 
-        if (iter != redirect_chain.end()) {
+        if (iter == redirect_chain.end()) {
           return false;
         }
 
         return true;
       });
 
-  filtered_conversions.erase(iter, filtered_conversions.end());
-
   return filtered_conversions;
 }