Skip to content

Commit

Permalink
Adjusting CookieSettingsWithMetadata overrides
Browse files Browse the repository at this point in the history
Chromium change:
https://chromium.googlesource.com/chromium/src/+/c49d628caa69138935c13e1c45edf6db1b1a6e34

commit 6d195126dbdf28b52aead93f68597bc7686455ac
Author: Brian Begnoche <bcb@chromium.org>
Date:   Fri Dec 16 17:12:14 2022 +0000

    Move all calling sites off deprecated CookieSettings::IsFullCookieAccessAllowed overloads.

    Bug: 1386190
  • Loading branch information
cdesouza-chromium committed Feb 9, 2023
1 parent 8df8121 commit 9b50bca
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions chromium_src/services/network/cookie_settings.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,14 @@
// we still want to block 3p frames as usual and not fall back to "allow
// everything" path.
#define BRAVE_COOKIE_SETTINGS_GET_COOKIE_SETTINGS_INTERNAL \
DCHECK(third_party_blocking_outcome == \
ThirdPartyBlockingOutcome::kIrrelevant); \
DCHECK(third_party_blocking_scope == absl::nullopt); \
if (is_third_party_request && \
ShouldBlockThirdPartyIfSettingIsExplicit( \
block_third_party_cookies_, cookie_setting, found_explicit_setting, \
base::Contains(third_party_cookies_allowed_schemes_, \
first_party_url.scheme()))) { \
third_party_blocking_outcome = \
ThirdPartyBlockingOutcome::kAllStateDisallowed; \
third_party_blocking_scope = \
ThirdPartyBlockingScope::kUnpartitionedAndPartitioned; \
cookie_setting = CONTENT_SETTING_BLOCK; \
} \
/* Store patterns information to determine if Shields are disabled. */ \
Expand Down

0 comments on commit 9b50bca

Please sign in to comment.