Skip to content

Commit

Permalink
Fix Brave's Welcome page
Browse files Browse the repository at this point in the history
The welcome page was not loading due to the following JS error:

  Uncaught ReferenceError: PromiseResolver is not defined
      at Object.sendWithPromise (cr.js:344)
      at welcomeUtils.ts:16
      at Object.dispatch (index.js:8)
      at Object.getSearchEngineProviders (redux.js:462)
      at loadWelcomeData (brave_welcome.tsx:26)
      at HTMLDocument.initialize (brave_welcome.tsx:31)

As it was also done already for brave_new_tab.html (search for
the "Fixes NTP" commit), we fix this error by doing this:

  - Removed import of cr.html as import has been deprecated
  - Added sourcing of promise_resolver.js to brave_welcome.html
  • Loading branch information
mariospr authored and mkarolin committed Sep 11, 2020
1 parent 8754e90 commit a6e01f4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/brave_welcome_ui/brave_welcome.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<title>Welcome to Brave</title>
<link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
<link rel="shortcut icon" href="favicon.ico" type="image/x-icon">
<link rel="import" href="chrome://resources/html/cr.html">
<script src="chrome://resources/js/promise_resolver.js"></script>
<script src="chrome://resources/js/cr.js"></script>
<script src="chrome://resources/js/load_time_data.js"></script>
<script src="chrome://resources/js/util.js"></script>
Expand Down

0 comments on commit a6e01f4

Please sign in to comment.