Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix for desktop mode option (uplift to 1.36.x) #12167

Closed
wants to merge 1 commit into from
Closed

[Android] Fix for desktop mode option (uplift to 1.36.x) #12167

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #12164
Resolves brave/brave-browser#20936

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team February 7, 2022 18:17
@brave-builds brave-builds self-assigned this Feb 7, 2022
@brave-builds brave-builds added this to the 1.36.x - Beta milestone Feb 7, 2022
@samartnik samartnik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 7, 2022
@kjozwiak kjozwiak closed this Feb 7, 2022
@kjozwiak kjozwiak deleted the pr12164_android_desktop_mode_fix_1.36.x branch February 7, 2022 21:49
@kjozwiak kjozwiak removed the request for review from a team February 7, 2022 21:49
@kjozwiak kjozwiak removed CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 7, 2022
@kjozwiak kjozwiak removed this from the 1.36.x - Beta milestone Feb 7, 2022
@kjozwiak kjozwiak restored the pr12164_android_desktop_mode_fix_1.36.x branch February 7, 2022 21:53
@kjozwiak kjozwiak requested a review from a team February 7, 2022 21:53
@kjozwiak kjozwiak reopened this Feb 7, 2022
@kjozwiak kjozwiak assigned samartnik and unassigned kjozwiak Feb 7, 2022
@kjozwiak kjozwiak added this to the 1.36.x - Beta milestone Feb 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Feb 8, 2022

Blocked due to brave/brave-browser#20963.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 8, 2022

Closing as #12164 was reverted and #12174 will be the fix that will be uplifted into 1.36.x & 1.35.x.

@kjozwiak kjozwiak closed this Feb 8, 2022
@kjozwiak kjozwiak deleted the pr12164_android_desktop_mode_fix_1.36.x branch February 8, 2022 02:56
@kjozwiak kjozwiak removed the request for review from a team February 8, 2022 02:56
@kjozwiak kjozwiak removed this from the 1.36.x - Beta milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@brave-builds @kjozwiak @samartnik @brave-browser-releases