Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first run startup crash due to welcome ui #153

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 11, 2018

This seems the regression from #130.
In that CL, BraveWelcomeUI WebUIController is introduced.
Because of this, current welcome ui page treated as webui.
This CL could be reverted when our local welcome ui is implemented.

close brave/brave-browser#315

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

This seems the regression from #130.
In that CL, BraveWelcomeUI WebUIController is introduced.
Because of this, current welcome ui page treated as webui.
This CL could be reverted when our local welcome ui is implemented.
@simonhong simonhong requested a review from bbondy June 11, 2018 07:21
@simonhong simonhong self-assigned this Jun 11, 2018
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is tracked in an issue and we will be converting to a local welcome page soon, merging.

@bbondy bbondy merged commit 2711d00 into master Jun 13, 2018
@simonhong simonhong deleted the fix_startup_crash_from_welcome_ui branch June 14, 2018 09:48
NejcZdovc added a commit that referenced this pull request Dec 10, 2018
Fixes too many results error
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
Fixes recovery key text area background on Linux
NejcZdovc added a commit that referenced this pull request Sep 18, 2019
Fixes recovery key text area background on Linux
NejcZdovc added a commit that referenced this pull request Sep 19, 2019
Fixes recovery key text area background on Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants