Branding in setting and extension pages

[yrliou]

Parts of solving brave/brave-browser#12, this PR involves

• Hide things without proper replacements available by adding <if expr="_google_chrome"> guards
• Copy generated_resources.grd and its sub files using l10nUtil.js to replace branding strings

I tried to utilize hidden and dom-if conditions which were pre-defined by chrome to avoid patching, unfortunately, usually those properties are shared between different elements that we don't want to hide, so it turned out to be patching case by case for most elements. The reason adding guards instead of using css is because those entries would still show up in searching results, so I prefer to not have those elements in the first place than hiding them. If there's a better way to do this, please feel free to suggest.

In the future, when we have our own extension store, most of the patches can be deleted, and only patching for cloud printer and chrome's password manager link sections will be left since we might not have these features in the short term.

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions

[yrliou]

There's an error when I try push_l10n, so I probably have some details missing, I'll add a commit to fix it ASAP.

[bridiver]

This looks like a lot of copying (grd and grdp files) so I think we should talk about other ways to do this.

[bridiver]

we're turning off accessibility settings?

[yrliou]

I'm removing this section because the only entry I could see is adding features by accessing chrome web store.

[bridiver]

ok, thanks

[yrliou]

By quick glancing those grd/grdp files again, we don't need to replace bookmarks_strings.grdp.
I will revisit this topic tomorrow to see what options we might have.

This looks like a lot of copying (grd and grdp files) so I think we should talk about other ways to do this.

[bridiver]

I think this needs to happen build-time and write to gen - https://github.com/brave/brave-browser/blob/master/lib/l10nUtil.js
I'll open an issue for a follow-up

[bridiver]

can you explain this change? I'm not sure what this is doing

[yrliou]

without preprocess=true, the <if expr> will not be parsed and was shown as <if expr=xxx> in the final HTML.

[bridiver]

ok, makes sense

[bbondy]

@yrliou can we pls do a substitution find and replace via the l10n scripts? I prefer not to patch grd files at all.

[bridiver]

oh, is it possible to change the attributes using that method? That's great if so

[bbondy]

Ya it's just find and replace, but we can find <structure name="IDR_MD_EXTENSIONS_SIDEBAR_HTML" and replace with <structure name="IDR_MD_EXTENSIONS_SIDEBAR_HTML" preprocess="true"

module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) =>
  Object.entries({
    [chromiumStringsPath]: braveStringsPath,
    [chroimumSettingsPartPath]: braveSettingsPartPath,
    [chromiumComponentsStringsPath]: braveComponentsStringsPath
  }).forEach(([sourcePath, destPath]) =>
    fs.writeFileSync(destPath,
      fs.readFileSync(sourcePath, 'utf8')
        .replace(/settings_chromium_strings.grdp/g, 'settings_brave_strings.grdp')
        .replace(/The Chromium Authors/g, 'Brave Software Inc')
        .replace(/Google Chrome/g, 'Brave')
        .replace(/Chromium/g, 'Brave')
        .replace(/Chrome/g, 'Brave')
        .replace(/Google/g, 'Brave'), 'utf8'))

[bridiver]

doesn't this give access to things like allowing extensions in incognito mode? Why do we want to hide it?

[yrliou]

This one is for the below part in settings->appearance->customized fonts.

So we'are hidding it in our build no matter what before our own extension store is ready.
For _google_chrome build, the condition !isGuest_ still stands.

[bridiver]

any reason not to also support that extension?

[yrliou]

Right now this extension is not supported yet, I'll open a follow up issue for handling this later.

[yrliou]

follow up issue created in brave/brave-browser#415

[bridiver]

we can override chrome_generated_resources.h in chromium_src to include our resources and then re-include chrome

[bridiver]

I think it would be better to specifically override things here vs repeating the entire list:
pageVisibility. a11y = false for instance

[bridiver]

or if we want our own completely independent list then maybe we should override IDR_SETTINGS_PAGE_VISIBILITY_JS ?

[yrliou]

pageVisibility would be undefined for non chrome os && not guest.
And sadly I couldn't only write the false values here because there are places using hidden=[[!pageVisibility.people]] which make undesired items to be hidden if the value was undefined.

I'll try overriding IDR_SETTINGS_PAGE_VISIBILITY_JS and see how it goes first thing tomorrow.

[bbondy]

ditto

[bbondy]

👍

[bbondy]

Oops I meant just to approve the last commit, let me cancel that approval.

accidental thought it was just the last commit.

[yrliou]

@bridiver @bbondy Thanks for the review comments, they are all addressed, please review this PR again, thanks!

[bridiver]

I don't think we care about anything for chromeos, or is this needed to avoid breaking something?

[yrliou]

this file is explicitly ignore here to avoid this script to try to process(read) this file, which we don't copy it at all into our src and caused read error.

[bridiver]

I think we should probably have a comment here explaining the reason why we used the proxy here vs just overriding individual settings. We don't want the next person who comes along to think that you can just override individual attributes like I assumed originally

[yrliou]

comments are added in 6b43657