Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents a crash on Android when Activity is not foreground and there is an attempt to set a default browser dialog (uplift to 1.51.x) #17925

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Prevents a crash on Android when Activity is not foreground and there is an attempt to set a default browser dialog (uplift to 1.51.x) #17925

merged 1 commit into from
Apr 11, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 5, 2023 •
edited by kjozwiak

Uplift of #17916
Resolves brave/brave-browser#29428

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner April 5, 2023 02:01
@brave-builds brave-builds self-assigned this Apr 5, 2023
@brave-builds brave-builds added this to the 1.51.x - Beta milestone Apr 5, 2023
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Apr 5, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

kjozwiak
kjozwiak approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.51.x approved 👍 QA has verified the PR on Nightly as per #17916 (comment).

@kjozwiak kjozwiak merged commit d819b97 into 1.51.x Apr 11, 2023
@kjozwiak kjozwiak deleted the pr17916_android_default_browser_crash_1.51.x branch April 11, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.51.x - Release
3 participants
@brave-builds @kjozwiak @SergeyZhukovsky