Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show vpn restore for no active subscription (uplift to 1.56.x) #18863

Closed
wants to merge 1 commit into from
Closed

Do not show vpn restore for no active subscription (uplift to 1.56.x) #18863

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #18847
Resolves brave/brave-browser#30244

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner June 12, 2023 14:43
@brave-builds brave-builds self-assigned this Jun 12, 2023
@brave-builds brave-builds added this to the 1.53.x - Beta milestone Jun 12, 2023
@mihaiplesa mihaiplesa changed the base branch from 1.53.x to 1.56.x July 6, 2023 19:48
@mihaiplesa mihaiplesa changed the title Do not show vpn restore for no active subscription (uplift to 1.53.x) Do not show vpn restore for no active subscription (uplift to 1.56.x) Jul 6, 2023
kjozwiak
kjozwiak approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the above as we're going to revert the change from 1.57.x via brave/brave-browser#31526. Once @deeppandya has a better solution, we can discuss uplifting into 1.57.x and possibly 1.56.x maintenance release.

@kjozwiak kjozwiak closed this Jul 8, 2023
@kjozwiak kjozwiak deleted the pr18847_hide_restore_vpn_for_no_subscription_1.53.x branch July 8, 2023 00:39
@kjozwiak kjozwiak removed this from the 1.56.x - Release milestone Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brave-builds @kjozwiak