Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent system theme change affect brave's theme in linux (uplift to 1.53.x) #19000

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Prevent system theme change affect brave's theme in linux (uplift to 1.53.x) #19000

merged 1 commit into from
Jun 28, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 22, 2023 •
edited by kjozwiak

Uplift of #18922
Resolves brave/brave-browser#30766

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong simonhong requested a review from a team as a code owner June 22, 2023 23:13
@simonhong simonhong self-assigned this Jun 22, 2023
@simonhong
Merge pull request #18922 from brave/linux_dark_theme
c3d7f3e 
Prevent system theme change affect brave's theme in linux
@kjozwiak kjozwiak added this to the 1.53.x - Release milestone Jun 28, 2023
kjozwiak
kjozwiak approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.53.x approved 👍 QA has verified the PR on Nightly as per #18922 (comment). We also have several reports of the above resolving user issues within the GH issue.

@kjozwiak kjozwiak merged commit d070b3f into 1.53.x Jun 28, 2023
10 checks passed
@kjozwiak kjozwiak deleted the linux_dark_theme-1.53.x branch June 28, 2023 21:50
@brunolpsousa brunolpsousa mentioned this pull request Jul 3, 2023
Closed
@brunolpsousa brunolpsousa mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.56.x - Release
2 participants
@simonhong @kjozwiak