Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable admin mode install of nightly on Windows #2005

Merged
merged 2 commits into from Mar 19, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 19, 2019

Fix brave/brave-browser#3728

I verified nightly standalone installer works with admin mode with this PR on my local Windows machine.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

yarn test brave_unit_tests Release --filter=InstallModes. NightlyModesTest

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong simonhong added this to the 0.64.x - Nightly milestone Mar 19, 2019
@simonhong simonhong self-assigned this Mar 19, 2019
@simonhong simonhong merged commit dd1df49 into master Mar 19, 2019
@simonhong simonhong deleted the enable_admin_install_of_nightly_on_windows branch March 19, 2019 01:42
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Modify updatePatches to make patches in chrome/app/theme
petemill pushed a commit that referenced this pull request Jul 27, 2020
Modify updatePatches to make patches in chrome/app/theme
petemill pushed a commit that referenced this pull request Jul 28, 2020
Modify updatePatches to make patches in chrome/app/theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants