Exponentials resend periods #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyBarabash
force-pushed
the
exponentials_resend_periods
branch
2 times, most recently
from
947f547
to
e9a8d6a
Compare
darkdh
reviewed
Jul 27, 2019
AlexeyBarabash
force-pushed
the
exponentials_resend_periods
branch
3 times, most recently
from
1f30022
to
1379e26
Compare
darkdh
reviewed
Jul 29, 2019
darkdh
reviewed
Jul 29, 2019
components/brave_sync/client/bookmark_change_processor_unittest.cc
Outdated
Show resolved
Hide resolved
components/brave_sync/client/bookmark_change_processor_unittest.cc
Outdated
Show resolved
Hide resolved
|
Will squash all those commits before merge. |
darkdh
previously approved these changes
Jul 30, 2019
Treat first send as not retry Exponential wait intervals are exported to test
Fix test for updated ClearOrderMap behaviour Updated test for treat first send as not retry Test imports exponential wait intervals from BookmarkChangeProcessor
AlexeyBarabash
force-pushed
the
exponentials_resend_periods
branch
from
6c1bf1d
to
2302246
Compare
darkdh
approved these changes
Jul 30, 2019
darkdh
added a commit
that referenced
this pull request
Aug 8, 2019
darkdh
added a commit
that referenced
this pull request
Aug 9, 2019
darkdh
added a commit
that referenced
this pull request
Aug 9, 2019
darkdh
added a commit
that referenced
this pull request
Aug 9, 2019
darkdh
added a commit
that referenced
this pull request
Aug 9, 2019
darkdh
added a commit
that referenced
this pull request
Aug 9, 2019
darkdh
added a commit
that referenced
this pull request
Aug 13, 2019
Resend meta shouldn't use metainfo from node (delete record doesn't have a node)
darkdh
added a commit
that referenced
this pull request
Aug 15, 2019
Resend meta shouldn't use metainfo from node (delete record doesn't have a node)
darkdh
added a commit
that referenced
this pull request
Aug 19, 2019
Resend meta shouldn't use metainfo from node (delete record doesn't have a node)
darkdh
added a commit
that referenced
this pull request
Aug 19, 2019
Resend meta shouldn't use metainfo from node (delete record doesn't have a node)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
Fixes brave/brave-browser#5356
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Specified in brave/brave-browser#5356 .
Reviewer Checklist:
After-merge Checklist:
changes has landed on.