Disable translate url fetcher request

[yrliou]

Fix brave/brave-browser#5829

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

auto test: npm test brave_unit_tests -- --filter=TranslateLanguageListTest.*
manual test plan is specified in brave/brave-browser#5829, browser connections could be observed using little snitch or similar tools.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[yrliou]

This PR will need to be uplifted to dev and beta, so I would like to separate this work into a follow up PR which only goes into master.

[yrliou]

Added this because we'll need to use our translate buildflags in the chromium_src override.

[pilgrim-brave]

If we need multiple patches anyway, why are we using chromium_src overrides?

[yrliou]

@pilgrim-brave If we subclass TranslateURLFetcher, we'll need 1) this one line deps patch. 2) two line patch in translate_url_fetcher.h for adding virtual keyword to its destructor and Request method. 3) one line patch to s/TranslateURLFetcher/BraveTranslateURLFetcher in translate_language_list.cc. 4) chromium_src override to s/TranslateURLFetcher/BraveTranslateURLFetcher in translate_script.cc.
Current PR has two lines less patching comparing to subclass it so I went for direct patching Request at first. I can change to subclass if that's more preferable in this case.

[yrliou]

Also, I don't foresee we'll need to override more methods on TranslateURLFetcher in the near future given how this class is right now. It's more likely that we might just decommission go-translate in the future at least for the desktops and then at that point we can go back to just one line patch in the Request method without this deps patch.

[pilgrim-brave]

OK I'll defer to @bridiver who might have ideas on further reducing the patches. Otherwise LGTM.

[bridiver]

I think we can just replace the class .h/.cc a minimal no-op dummy class in chromium_src and avoid the second patch. We'll still need this for the buildflag dep, but at least this is an extensible patch that allows us to add more deps to this component if we need them later

[bridiver]

also @pilgrim-brave just for reference, if we don't make the change I suggested we would still use a chromium_src override for the second patch because it decreases the size of the patch and also allows us to change the code in the patch without changing the patch itself. Using a define for patches is now the preferred approach for that reason.

[yrliou]

Created a dummy impl as @bridiver suggested and got rid of the other patching in 9244c81.

[yrliou]

Subclass this seems to require more patching to me, at least one line in translate_url_fetcher.h and one line in translate_language_list.cc, and the deps patch.

[yrliou]

Removed in 9244c81

[yrliou]

Encountered known intermittent error below at windows-x64, which is not related to this PR.
This audit-dep step is green on all other platforms and it was all green in the previous try before the last commit, which should be safe enough.

13:53:42  Auditing C:\jenkins\workspace\le_translate_url_fetcher_request
13:53:42  C:\jenkins\workspace\le_translate_url_fetcher_request: npm audit
13:53:56  
13:53:56  powershell.exe : npm ERR! code ENOAUDIT
13:53:56  At C:\jenkins\workspace\le_translate_url_fetcher_request@tmp\durable-d6ca13c4\powershellWrapper.ps1:3 char:1
13:53:56  + & powershell -NoProfile -NonInteractive -ExecutionPolicy Bypass -Comm ...
13:53:56  + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
13:53:56      + CategoryInfo          : NotSpecified: (npm ERR! code ENOAUDIT:String) [], RemoteException
13:53:56      + FullyQualifiedErrorId : NativeCommandError
13:53:56   
13:53:56  npm ERR! audit Your configured registry (https://registry.npmjs.org/) does not support audit requests.