Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 81.0.4044.113 to Chromium 81.0.4044.122. (uplift to 1.7.x) #5326

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Upgrade from Chromium 81.0.4044.113 to Chromium 81.0.4044.122. (uplift to 1.7.x) #5326

merged 1 commit into from
Apr 24, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Apr 22, 2020 •
edited by kjozwiak

Uplift of #5309
Fixes brave/brave-browser#9453
Related brave/brave-browser#9402

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.7.x - Release Hotfix 2 milestone Apr 22, 2020
@bsclifton bsclifton requested a review from a team April 22, 2020 22:38
@bsclifton bsclifton self-assigned this Apr 22, 2020
@kjozwiak
Copy link
Member

Restarting Win x64 due to init failing as per https://ci.brave.com/job/brave-browser-build-pr/job/PR-9402/2/execution/node/173/log/.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 23, 2020
@bsclifton
Merge pull request #5309 from brave/81.0.4044.122
ecfb32d 
Upgrade from Chromium 81.0.4044.113 to Chromium 81.0.4044.122.
@bsclifton
Copy link
Member Author

CI looks great! Completely green. Travis-CI has issues because we never backported the npm audit fixes

@bsclifton bsclifton mentioned this pull request Apr 24, 2020
Merged
4 tasks
kjozwiak
kjozwiak approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 02be267 into 1.7.x Apr 24, 2020
@kjozwiak kjozwiak deleted the 81.0.4044.122-1.7.x branch April 24, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@bsclifton bsclifton

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.7.x - Release Hotfix 2
2 participants
@bsclifton @kjozwiak