Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable translation service, disable TranslateURLFetcher, hide associated UI in preferences #562

Merged
merged 5 commits into from Oct 4, 2018
Merged

disable translation service, disable TranslateURLFetcher, hide associated UI in preferences #562

merged 5 commits into from Oct 4, 2018

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Oct 3, 2018 •
edited

Fix brave/brave-browser#663

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@pilgrim-brave pilgrim-brave self-assigned this Oct 3, 2018
bbondy
bbondy requested changes Oct 4, 2018
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just the HTML update for now.

patches/chrome-browser-resources-settings-languages_page-languages_page.html.patch Outdated Show resolved Hide resolved
patches/chrome-browser-resources-settings-languages_page-languages_page.html.patch Outdated Show resolved Hide resolved
patches/components-translate-core-browser-translate_url_fetcher.cc.patch Show resolved Hide resolved
patches/components-translate-core-browser-language_state.h.patch Show resolved Hide resolved
@bbondy
Copy link
Member

bbondy commented Oct 4, 2018

Please also add a browser test to ensure that TranslateURLFetcher::Request returns false

@bridiver
Copy link
Collaborator

bridiver commented Oct 4, 2018

@pilgrim-brave sometimes the changes will seem a bit odd when we're patching, but the goal is to either avoid patching or make the patch smaller because they are easier to maintain that way

@bbondy bbondy merged commit 8eec750 into brave:master Oct 4, 2018
bbondy pushed a commit that referenced this pull request Oct 4, 2018
@pilgrim-brave @bbondy
disable translation service, disable TranslateURLFetcher, hide associ…
27d0600 
…ated UI in preferences (#562)

* disable translation service, disable TranslateURLFetcher, hide associated UI in preferences

Fix brave/brave-browser#663

* use comments

* unit test
bbondy pushed a commit that referenced this pull request Oct 4, 2018
@pilgrim-brave @bbondy
disable translation service, disable TranslateURLFetcher, hide associ…
3351db7 
…ated UI in preferences (#562)

* disable translation service, disable TranslateURLFetcher, hide associated UI in preferences

Fix brave/brave-browser#663

* use comments

* unit test
@bbondy
Copy link
Member

bbondy commented Oct 4, 2018

master: 8eec750
0.56.x: 27d0600
0.55.x: 3351db7

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
yrliou added a commit that referenced this pull request Mar 19, 2019
@yrliou
Revert "disable translation service, disable TranslateURLFetcher, hid…
0dda503 
…e associated UI in preferences (#562)"

This reverts commit 8eec750.
yrliou added a commit that referenced this pull request Mar 19, 2019
@yrliou
Revert "disable translation service, disable TranslateURLFetcher, hid…
f7c9b11 
…e associated UI in preferences (#562)"

This reverts commit 8eec750.
yrliou added a commit that referenced this pull request Mar 21, 2019
@yrliou
Revert "disable translation service, disable TranslateURLFetcher, hid…
9d92697 
…e associated UI in preferences (#562)"

This reverts commit 8eec750.
yrliou added a commit that referenced this pull request Apr 3, 2019
@yrliou
Revert "disable translation service, disable TranslateURLFetcher, hid…
b6d9c23 
…e associated UI in preferences (#562)"

This reverts commit 8eec750.
yrliou added a commit that referenced this pull request Apr 3, 2019
@yrliou
Revert "disable translation service, disable TranslateURLFetcher, hid…
5f350ed 
…e associated UI in preferences (#562)"

This reverts commit 8eec750.
yrliou added a commit that referenced this pull request Apr 4, 2019
@yrliou
Revert "disable translation service, disable TranslateURLFetcher, hid…
15d2fd6 
…e associated UI in preferences (#562)"

This reverts commit 8eec750.
pilgrim-brave pushed a commit that referenced this pull request Apr 16, 2019
@yrliou @pilgrim-brave
Revert "disable translation service, disable TranslateURLFetcher, hid…
2572759 
…e associated UI in preferences (#562)"

This reverts commit 8eec750.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver left review comments

@bbondy bbondy bbondy approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
3 participants
@pilgrim-brave @bbondy @bridiver