Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPFS option for Gateway vs Ask #6583

Merged
merged 1 commit into from Sep 8, 2020
Merged

Add IPFS option for Gateway vs Ask #6583

merged 1 commit into from Sep 8, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 4, 2020

...Otherwise all gateway loads would ask the user to install the local daemon

Fix brave/brave-browser#11562

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Otherwise all gateway loads would ask the user to install the local daemon
@bbondy bbondy requested a review from yrliou September 4, 2020 20:52
@bbondy bbondy self-assigned this Sep 4, 2020
fmarier pushed a commit to fmarier/brave-core that referenced this pull request Sep 5, 2020
allow npm config override of target_os and target_arch for android/io…
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit c023b2d into master Sep 8, 2020
@bbondy bbondy deleted the ipfs-ask branch September 8, 2020 20:32
@bbondy bbondy added this to the 1.16.x - Nightly milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants