Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the Moonpay/Bitcoin.com widget [1.18] #7146

Merged
merged 1 commit into from Nov 18, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 14, 2020

Fixes: brave/brave-browser#12699
Uplifts: #7145

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@ryanml ryanml added this to the 1.18.x - Beta milestone Nov 14, 2020
@ryanml ryanml requested a review from a team November 14, 2020 23:39
@ryanml ryanml self-assigned this Nov 14, 2020
@ryanml ryanml changed the title Disabling the Moonpay/Bitcoin.com widget Disabling the Moonpay/Bitcoin.com widget [1.18] Nov 14, 2020
@kjozwiak
Copy link
Member

test-browser failed on Win x64 as per https://ci.brave.com/job/pr-brave-browser-remove-bdc-1.18-windows/1/execution/node/247/log/. Created brave/brave-browser#12704. However, test-browser failures don't block uplifts.

[  FAILED  ] RewardsBrowserTest.UpholdLimitNoBAT, where TypeParam =  and GetParam() =  (23110 ms)

Restarting macOS as there was a bunch of test-browser failures as per https://ci.brave.com/job/pr-brave-browser-remove-bdc-1.18-macos/1/execution/node/251/log/.

Restarting Linux as there was a bunch of test-browser failures as per https://ci.brave.com/job/pr-brave-browser-remove-bdc-1.18-linux/1/execution/node/251/log/.

Disabling the Moonpay/Bitcoin.com widget
@kjozwiak
Copy link
Member

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-remove-bdc-1.18-macos/3/execution/node/251/log/

19:50:53  3 tests failed:
19:50:53      RewardsBrowserTest.UpholdLimitNoBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:399)
19:50:53      RewardsContributionBrowserTest.TipConnectedPublisherVerified (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:587)
19:50:53      RewardsPromotionBrowserTest.PromotionRemovedFromEndpoint (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:232)
19:50:53  2 tests crashed:
19:50:53      BraveContentBrowserClientTest.RewriteChromeSync (../../brave/browser/brave_content_browser_client_browsertest.cc:215)
19:50:53      RewardsBrowserTest.ToggleAutoContribute (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:132)

test-browser failed on Linux due to BraveContentBrowserClientTest.RewriteChromeSync crashing as per https://ci.brave.com/job/pr-brave-browser-remove-bdc-1.18-linux/3/execution/node/251/log/.

18:56:39  1 test crashed:
18:56:39      BraveContentBrowserClientTest.RewriteChromeSync (../../brave/browser/brave_content_browser_client_browsertest.cc:215)

Looks like Win x64 had some issues starting due to AWS. Restarting.

Created brave/brave-browser#12753 for the BraveContentBrowserClientTest.RewriteChromeSync issue but the rest appear to be rewards related which isn't related to this PR.

@kjozwiak
Copy link
Member

test-browser failed on Win x64 due to BraveContentBrowserClientTest.RewriteChromeSync crashing as per https://ci.brave.com/job/pr-brave-browser-remove-bdc-1.18-windows/7/execution/node/247/log/.

22:41:06  1 test crashed:
22:41:06      BraveContentBrowserClientTest.RewriteChromeSync (../../brave/browser/brave_content_browser_client_browsertest.cc:215)

Created brave/brave-browser#12753 for the BraveContentBrowserClientTest.RewriteChromeSync issue but the rest appear to be rewards related which isn't related to this PR.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly via #7145 (comment).

@kjozwiak kjozwiak merged commit fed10db into 1.18.x Nov 18, 2020
@kjozwiak kjozwiak deleted the remove-bdc-1.18 branch November 18, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants