Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable PushClientChannel #912

Merged
merged 1 commit into from Nov 15, 2018
Merged

Disable PushClientChannel #912

merged 1 commit into from Nov 15, 2018

Conversation

pilgrim-brave
Copy link
Contributor

Fixes brave/brave-browser#2141

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@pilgrim-brave pilgrim-brave self-assigned this Nov 15, 2018
@pilgrim-brave pilgrim-brave merged commit e91cf89 into master Nov 15, 2018
@NejcZdovc NejcZdovc deleted the mpilgrim_push_client_channel branch November 16, 2018 06:13
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
bridiver
bridiver reviewed May 10, 2019
View reviewed changes
patches/components-invalidation-impl-push_client_channel.cc.patch
: push_client_(std::move(push_client)),
scheduling_hash_(0),
sent_messages_count_(0) {
+ return; // feature disabled in Brave
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these patches can also be removed with a chromium_src override on SyncNetworkChannel to subclass PushClientChannel

goodov added a commit that referenced this pull request Sep 20, 2022
@goodov
Merge pull request #15130 from /issues/912
5ddf131 
Fix few more ASAN issues in tests.
This was referenced May 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver left review comments

@bbondy bbondy bbondy approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
3 participants
@pilgrim-brave @bridiver @bbondy