Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Commit

Permalink
Fix for review
Browse files Browse the repository at this point in the history
  • Loading branch information
cuba committed Jan 2, 2024
1 parent 3aab681 commit 3866f7a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -357,10 +357,10 @@ extension BrowserViewController: WKNavigationDelegate {
isAggressiveMode: domain.blockAdsAndTrackingLevel.isAggressive
)

if shouldBlock {
if shouldBlock, let escapingURL = requestURL.absoluteString.escape() {
var components = URLComponents(string: InternalURL.baseUrl)
components?.path = "/\(InternalURL.Path.blocked.rawValue)"
components?.queryItems = [URLQueryItem(name: "url", value: requestURL.absoluteString.escape()!)]
components?.queryItems = [URLQueryItem(name: "url", value: escapingURL)]

if let url = components?.url {
let request = PrivilegedRequest(url: url) as URLRequest
Expand Down
14 changes: 7 additions & 7 deletions Sources/BraveShields/ShieldStrings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -151,29 +151,29 @@ public extension Strings.Shields {

public extension Strings.Shields {
/// A tab title that appears when a page was blocked
static let domianBlockedTitle = NSLocalizedString(
static let domainBlockedTitle = NSLocalizedString(
"DomainBlockedTitle", tableName: "BraveShared", bundle: .module,
value: "Domain Blocked",
comment: "A tab title for the warning page that appears when a page was blocked"
)

/// A title in the warning page that appears when a page was blocked
static let domianBlockedPageTitle = NSLocalizedString(
"DomianBlockedPageTitle", tableName: "BraveShared", bundle: .module,
static let domainBlockedPageTitle = NSLocalizedString(
"DomainBlockedPageTitle", tableName: "BraveShared", bundle: .module,
value: "This Site May Attempt to Track You Across Other Sites",
comment: "A title in the warning page that appears when a page was blocked"
)

/// A title in the warning page that appears when a page was blocked
static let domianBlockedPageMessage = NSLocalizedString(
"DomianBlockedPageMessage", tableName: "BraveShared", bundle: .module,
static let domainBlockedPageMessage = NSLocalizedString(
"DomainBlockedPageMessage", tableName: "BraveShared", bundle: .module,
value: "Brave has prevented the following site from loading:",
comment: "A message in the warning page that appears when a page was blocked"
)

/// A description in the warning page that appears when a page was blocked
static let domianBlockedPageDescription = NSLocalizedString(
"DomianBlockedPageDescription", tableName: "BraveShared", bundle: .module,
static let domainBlockedPageDescription = NSLocalizedString(
"DomainBlockedPageDescription", tableName: "BraveShared", bundle: .module,
value: "Because you requested to aggressively block trackers and ads, Brave is blocking this site before the first network connection.",
comment: "A description in the warning page that appears when a page was blocked"
)
Expand Down

0 comments on commit 3866f7a

Please sign in to comment.