Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Finalize Copy #246

Closed
2 tasks
jhreis opened this issue Sep 10, 2018 · 5 comments
Closed
2 tasks

Finalize Copy #246

jhreis opened this issue Sep 10, 2018 · 5 comments
Labels
blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue enhancement

Comments

@jhreis
Copy link
Contributor

jhreis commented Sep 10, 2018

Copy across entire application must be finalized.

  • Get finalized strings for entire application from design
  • Add in new copy
@jhreis jhreis added blocked: needs design Needs design before work can commence blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue l10n labels Sep 10, 2018
@tmancey tmancey changed the title Finalize 1.7 Copy Finalize Copy Sep 10, 2018
@tmancey tmancey added enhancement blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue and removed blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue labels Sep 10, 2018
@tmancey
Copy link
Collaborator

tmancey commented Sep 10, 2018

@anthonypkeane Blocked as need final Copy from design

@anthonypkeane
Copy link

Update:

@srirambv will go through and audit the entire app to verify strings are good or places that need modifications. All menus, button options, descriptions, etc

Once 1.7/v2 is ready, please share it with @srirambv and @anthonypkeane and this task can kick off. Thanks

@tmancey tmancey removed the blocked: needs design Needs design before work can commence label Sep 21, 2018
@anthonypkeane
Copy link

@jhreis and @tmancey , if you guys can provide a final .strings file, I can move forward with getting the missing strings and getting the .strings file translated. We should make sure there is no (or minimal) strings from V1.6 so we are not translating words we won’t use.

cc @srirambv

@jhreis
Copy link
Contributor Author

jhreis commented Sep 28, 2018

@anthonypkeane not sure a massive, random strings file is the best way to audit the app's string usages. It will probably be more necessary to go through the entire app and validate the strings in English that way. We can still provide a strings file, may just be hard without any context.

@tmancey
Copy link
Collaborator

tmancey commented Oct 9, 2018

@jhreis @anthonypkeane I would recommend string comments are first updated/added for every string after running the clean-nslocalizedstrings script so translators have a better context as to the use of each string.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue enhancement
Projects
None yet
Development

No branches or pull requests

3 participants