Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Crash when set as default browser and opening link from other app #3041

Closed
cwmke opened this issue Nov 14, 2020 · 1 comment · Fixed by #3049
Closed

Crash when set as default browser and opening link from other app #3041

cwmke opened this issue Nov 14, 2020 · 1 comment · Fixed by #3049
Assignees
@soner-yuksel
Labels
bug crash Epic: Performance iOS 14 QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.22

Comments

@cwmke
Copy link

cwmke commented Nov 14, 2020

Description:

Links opened with the tabs overview left open in Brave leads to a crash.

Steps to Reproduce

  1. Set Brave as default browser.
  2. Click the show all tabs button (leave it open.)
  3. Go to another app and open a link.
  4. Brave crashes.

Actual result:
Crash

Expected result:
Pressed link opens in a new tab probably without exiting the overview.

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproduced.

Brave Version:
Version 1.21 (20.11.10.16) Device iPhone12,3 (iOS 14.2)
Version 1.21 (20.11.10.16) Device iPad8,10 (iOS 14.2)

Device details:
iPhone 11 Pro; iPad Pro (11-inch) (2nd generation)
@anthonypkeane anthonypkeane added this to the 1.22 milestone Nov 16, 2020
@soner-yuksel soner-yuksel self-assigned this Nov 16, 2020
@soner-yuksel soner-yuksel mentioned this issue Nov 17, 2020
Merged
7 tasks
iccub pushed a commit that referenced this issue Nov 18, 2020
@soner-yuksel
Fix #3041: TabTray is not being dismissed when actual controller is n…
e90bee9 
…ot TabTray but Data is inserted to indexpaths (#3049)
iccub pushed a commit that referenced this issue Nov 18, 2020
@soner-yuksel @iccub
Fix #3041: TabTray is not being dismissed when actual controller is n…
bb19eb5 
…ot TabTray but Data is inserted to indexpaths (#3049)
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.2 running 1.22(20.11.24.17)

  • Verified steps from issue description
  • Verified no crash when switching to Brave from other app

Verification passed on iPad Pro with iOS 14.2 running 1.22(20.11.24.17)

  • Verified steps from issue description
  • Verified no crash when switching to Brave from other app

@kjozwiak kjozwiak mentioned this issue Dec 11, 2020
Closed
@bsclifton bsclifton mentioned this issue Dec 11, 2020
Merged
7 tasks
@soner-yuksel soner-yuksel mentioned this issue Jan 20, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
bug crash Epic: Performance iOS 14 QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.22
Development

Successfully merging a pull request may close this issue.

Fix #3041: Crash when set as Default Browser and opening Link from other Application brave/brave-ios
5 participants
@cwmke @soner-yuksel @iccub @anthonypkeane @srirambv