Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update default browser notification to display device's iOS version #3899

Closed
iccub opened this issue Jul 7, 2021 · 7 comments · Fixed by #3911
Closed

Update default browser notification to display device's iOS version #3899

iccub opened this issue Jul 7, 2021 · 7 comments · Fixed by #3911

Comments

@iccub
Copy link
Collaborator

iccub commented Jul 7, 2021

Description:

This notification should show user's device version instead of hardcoding iOS 14
On code side this requires change in NSLocalized string, the number has to be replaced with a number placeholder.
Then in app we have to fetch device's iOS version, with iOS 14 minimum, since iOS 13 can't be set as a default

File

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@Shivakumar-SG
Copy link

Hey @iccub, I would like to take up this issue!
will you please give me a head start?

@iccub
Copy link
Collaborator Author

iccub commented Jul 9, 2021

sure @Shivakumar-SG, find this notification in app, see how is it implemented.
You have to change it from a hardcoded string to a string with a placeholder,

Then this placeholder will be number of device's iOS version, so for iOS 14 it will be 14, for 15=15 etc.

@Shivakumar-SG
Copy link

Hey, I'm kinda new to Xcode and my Xcode app kept crashing and I don't know why. And adding to that, I know git ignores the entire Local directory but I don't have an Apple team ID so, I'm not taking this issue on and letting the community know that this issue is still up for grabs!
Thank you.

@iccub
Copy link
Collaborator Author

iccub commented Jul 10, 2021

thank you for trying @Shivakumar-SG :)
You can get apple id for free now btw

@ionutivan
Copy link

@iccub If nobody is on this issue yet, I would like to take it. Thanks

@iccub
Copy link
Collaborator Author

iccub commented Jul 12, 2021

@ionutivan I believe one user has started work on it already, but this PR requires changes
#3911

@srirambv
Copy link
Contributor

srirambv commented Oct 8, 2021

Verification passed on the following devices running 1.32(21.10.6.16)

  • Verified default browser notification shows device iOS Version
iPhone 7+ (iOS 14.8) iPhone XR (iOS 15.0.1) iPad Pro (iOS 15.1 Beta 3)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.