Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update setting for Playlist toast #4098

Closed
jamesmudgett opened this issue Aug 27, 2021 · 1 comment · Fixed by #4106
Closed

Update setting for Playlist toast #4098

jamesmudgett opened this issue Aug 27, 2021 · 1 comment · Fixed by #4106
Assignees
@Brandon-T
Labels
enhancement Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.31

Comments

@jamesmudgett
Copy link
Contributor

Title: Show Menu Notification Badge
Description: When enabled, a badge will be displayed on the main menu icon, indicating media on the page may be added to Brave Playlist.
Default: true

IMG_2943
@jamesmudgett jamesmudgett added this to the 1.31 milestone Aug 27, 2021
@Brandon-T Brandon-T mentioned this issue Aug 30, 2021
Merged
7 tasks
iccub pushed a commit that referenced this issue Aug 30, 2021
@Brandon-T
Fix #4098: Add playlist menu preference for badge icon. (#4106)
a9f8e39
iccub pushed a commit that referenced this issue Aug 30, 2021
@Brandon-T @iccub
Fix #4098: Add playlist menu preference for badge icon. (#4106)
e8d1d60
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.31(21.9.14.15)

  • Verified test plan from #4106
  • Verified setting is enabled by default
  • Verified when setting is enabled badge is show no menu
  • Verified when setting is disabled badge is not shown on menu
Setting On Setting Off Badge Shown Badge Hidden
image image image image

Verification passed on iPhone 7+ with iOS 14.8 running 1.31(21.9.14.15)

  • Verified test plan from #4106
  • Verified setting is enabled by default
  • Verified when setting is enabled badge is show no menu
  • Verified when setting is disabled badge is not shown on menu
Setting On Setting Off Badge Shown Badge Hidden
image image image image

Verification passed on iPad Pro with iOS 15 running 1.31(21.9.14.15)

  • Verified test plan from #4106
  • Verified setting is enabled by default
  • Verified when setting is enabled badge is show no menu
  • Verified when setting is disabled badge is not shown on menu
Setting On Setting Off Badge Shown Badge Hidden
image image image image

@srirambv srirambv mentioned this issue Sep 20, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
enhancement Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.31
Development

Successfully merging a pull request may close this issue.

Fix #4098 - Added playlist menu preference for badge icon. brave/brave-ios
4 participants
@jamesmudgett @Brandon-T @iccub @srirambv