Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Tab appears "black" when tab next to it is closed #4149

Closed
Brave-Matt opened this issue Sep 9, 2021 · 6 comments · Fixed by #4151
Closed

Tab appears "black" when tab next to it is closed #4149

Brave-Matt opened this issue Sep 9, 2021 · 6 comments · Fixed by #4151

Comments

@Brave-Matt
Copy link

Description:

If at least two tabs are open, closing one of the tabs (using the x) causes the tab to the immediate left of the closed tab to appear blank. Refresh does not fix the black screen — you have to move to a different tab, then back again for the site content to appear.

Steps to Reproduce

  1. Open 3 tabs (for example) to different sites
  2. Select the middle tab
  3. Close the middle tab
  4. Tab to left is automatically selected, observe “black” webpage contents

Actual result:

RPReplay_Final1631215086.MP4

Expected result:
Contents should not appear black

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

Brave Version:
v1.30.1

Device details:
iPad and iPhone

Website problems only:

  • did you check with Brave Shields down? N/A
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A
@iccub iccub added this to the 1.31 milestone Sep 10, 2021
iccub pushed a commit that referenced this issue Sep 13, 2021
This is because they put an invisible video player there with no "src" and webkit thinks it's playing something.
Next is a race-condition for the tab's visibility state vs. whether it is playing. This is fixed.
iccub pushed a commit that referenced this issue Sep 13, 2021
This is because they put an invisible video player there with no "src" and webkit thinks it's playing something.
Next is a race-condition for the tab's visibility state vs. whether it is playing. This is fixed.
@srirambv
Copy link
Contributor

Verification passed on iPad Pro with iOS 15 running 1.31(21. 9.14.15)

  • Verified closing tab doesn't cause the previous tab to appear blank

Verification passed on iPhone 7+ with iOS 14.8 running 1.31(21. 9.14.15)

  • Verified closing tab doesn't cause the previous tab to appear blank

Verification passed on iPhone XR with iOS 13.5 running 1.31(21. 9.14.15)

  • Verified closing tab doesn't cause the previous tab to appear blank

@danawoodman
Copy link

I'm getting this with Version 1.30.1 (21.8.17.19) Device iPhone13,3 (iOS 14.7.1)

@iccub
Copy link
Collaborator

iccub commented Sep 20, 2021

This is fixed in 1.31 @danawoodman, you can go to app store and update the app, it's live

@danawoodman
Copy link

Weird, for some reason my phone wasn't auto updating the app. Downloaded the update and it works, thanks!

@iccub
Copy link
Collaborator

iccub commented Sep 20, 2021

No worries :) glad it works for you
the release is at staged rollout at the moment, 10% of users got it, it will be 100% of users later this week

@danawoodman
Copy link

Ah that makes sense!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.