Receiving tab from desktop app should show correct legend on notification banner

[Uni-verse]

Description:

Receiving tab from desktop app should show correct legend on notification banner

Steps to Reproduce

1. Connect desktop and mobile apps to sync chain
2. Send page to mobile app from desktop
3. Observe notification banner legend on mobile

Actual result:

Example	Example	Example

Expected result:
When sending from desktop app, it should show desktop legend on mobile client.

Brave Version:
1.43.x

Device details:
iPhone, iPad

[soner-yuksel]

So I tried to handle this case but it turns out changing the icon according to device will not be possible.

However,

I tried to match sync cache ids for receiver and sender but they didn't match with the ones from device list for sender list and receiver device. So the only option is to use what Chromium provides under send_tab_to_self::SendTabToSelfEntry

From Chromium we receive send_tab_to_self::SendTabToSelfEntry when we receive a tab and this information contains

URL - Title - Time when it is shared - Device Name

When desktop receives a Tab from another they utilize all the information and use a popup like this

They use title url and device name to to utilize the information.

So what I believe even we cant change the icon we should improve the Toast which is showing "Tab Received" using additional information like URL - Title - Device Name.

@stoletheminerals also mentioned this in original PR brave/brave-ios#5809 (comment)

Please tell me what do you think about it ?
@iccub @stoletheminerals @Uni-verse

[stoletheminerals]

So what I believe even we cant change the icon we should improve the Toast which is showing "Tab Received" using additional information like URL - Title - Device Name.

I agree. Ideally, we should have parity with Desktop and Android. Showing URL should be a bare minimum.