Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Adding favorite without http/https prefix doesn't load favicon even after visiting site #971

Closed
LaurenWags opened this issue Mar 14, 2019 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description:

Found while testing #739

Adding favorite without http/https prefix doesn't load the site favicon even after you visit the site.

Steps to Reproduce

  1. Clean profile on 1.9 (19.3.9.1)
  2. Edit a favorite and add title as Github and replace url with github.com (no favicon)
  3. Load the edited favorite, site loads.
  4. Open a new tab.

Actual result:
Edited favorite doesn't have a favicon (lower left one)
Image from iOS

Expected result:
Favicon would load after site was visited

Reproduces how often: [Easily reproduced, Intermittent Issue]
easily

Brave Version:
1.9 (19.3.9.1)

Device details:
All

Website problems only:

  • did you check with Brave Shields down? n/a
  • did you check in Safari/Firefox (WkWebView-based browsers)? no

Additional Information

@btlechowski
Copy link

Reproduced with 1.9 (19.3.9.1) on iPhone SE

@GeetaSarvadnya
Copy link

Similar to #572

@srirambv
Copy link
Contributor

Closing as dupe of #572

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants