Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3884 / 3688 : Quick Search Bar Bugs #3885

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

soner-yuksel
Copy link
Member

@soner-yuksel soner-yuksel commented Jul 5, 2021

This Pr is fixing Keyboard and Search Bar Overlapand Search Bar Safe Area Bottom

Summary of Changes

This pull request fixes #3688
This pull request fixes #3884

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Same Test Plans inside both of the tickets.

Screenshots:

#3688

Simulator.Screen.Recording.-.iPhone.8.Plus.-.2021-07-05.at.14.08.01.mp4

#3884

Simulator.Screen.Recording.-.iPhone.12.-.2021-07-05.at.14.20.21.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

Search Bar safe Are fix
@soner-yuksel soner-yuksel added this to the 1.29 milestone Jul 5, 2021
@soner-yuksel soner-yuksel requested a review from a team July 5, 2021 18:21
@soner-yuksel soner-yuksel self-assigned this Jul 5, 2021
Copy link
Collaborator

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky, i hope it does not break anything :D
does it work well in iPad multitasking mode? compact/regular width

@soner-yuksel
Copy link
Member Author

Tricky, i hope it does not break anything :D
does it work well in iPad multitasking mode? compact/regular width

Yes tested it, there was no problem but since the problem for bar overlap only exists in iPhone, I will add a check for it.

@soner-yuksel soner-yuksel merged commit 4bfcca2 into development Jul 6, 2021
@soner-yuksel soner-yuksel deleted the fix/quick-search-bar branch July 6, 2021 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants