This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 442
[v1.59] Fix #7866: AccountId Transaction Refactor, BraveCore v1.59.59 #7997
Merged
StephenHeaps
merged 3 commits into
brave-core-1.59.x
from
wallet/accountId-transaction-refactor
Sep 6, 2023
Merged
[v1.59] Fix #7866: AccountId Transaction Refactor, BraveCore v1.59.59 #7997
StephenHeaps
merged 3 commits into
brave-core-1.59.x
from
wallet/accountId-transaction-refactor
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soner-yuksel
approved these changes
Aug 30, 2023
nuo-xu
approved these changes
Aug 31, 2023
StephenHeaps
added a commit
that referenced
this pull request
Sep 6, 2023
nuo-xu
pushed a commit
that referenced
this pull request
Sep 13, 2023
StephenHeaps
added a commit
that referenced
this pull request
Sep 14, 2023
StephenHeaps
added a commit
that referenced
this pull request
Sep 18, 2023
StephenHeaps
added a commit
that referenced
this pull request
Sep 19, 2023
* Update BraveCore to v1.59.41 * [v1.59] Fix #7866: AccountId Transaction Refactor, BraveCore v1.59.59 (#7997) * Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates. * Update BraveCore to v1.59.59 * Disable failing `testCompilationofResources` test. * upgrade brave core to 1.59.84 --------- Co-authored-by: Nuo Xu <nuoxu.nx@gmail.com>
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
…8077) * Update BraveCore to v1.59.41 * [v1.59] Fix brave/brave-ios#7866: AccountId Transaction Refactor, BraveCore v1.59.59 (brave/brave-ios#7997) * Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates. * Update BraveCore to v1.59.59 * Disable failing `testCompilationofResources` test. * upgrade brave core to 1.59.84 --------- Co-authored-by: Nuo Xu <nuoxu.nx@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
AccountId
model instead of from address for most transaction methods.AccountId
address for most lookups; this will change eventually with Bitcoin (array of from addresses instead of a single from address) but not yet determined exactly how.This pull request fixes #7866
Submitter Checklist:
NSLocalizableString()
Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement