Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[v1.59] Fix #7866: AccountId Transaction Refactor, BraveCore v1.59.59 #7997

Merged

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

  • Relatively easy change of using AccountId model instead of from address for most transaction methods.
  • Using AccountId address for most lookups; this will change eventually with Bitcoin (array of from addresses instead of a single from address) but not yet determined exactly how.

This pull request fixes #7866

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Verify creating Send transactions is still working as expected for all coin types (verify from account is correct).
  2. Verify creating Swap transactions is still working as expected for all coin types (verify from account is correct).
  3. Verify Tx Confirmation showing transactions as expected, transactions show in Activity tab, Asset Detail & Account Detail.
  4. Verify correct account displayed in Encrypt / Decrypt request (create request, dismiss request without cancel/approve, change accounts & verify account encryption request is for still shown).

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps added this to the 1.58 milestone Aug 30, 2023
@StephenHeaps StephenHeaps requested a review from a team as a code owner August 30, 2023 20:38
@StephenHeaps StephenHeaps self-assigned this Aug 30, 2023
@StephenHeaps StephenHeaps modified the milestones: 1.58, 1.59 Sep 6, 2023
@StephenHeaps StephenHeaps merged commit 2045bca into brave-core-1.59.x Sep 6, 2023
5 checks passed
@StephenHeaps StephenHeaps deleted the wallet/accountId-transaction-refactor branch September 6, 2023 19:05
StephenHeaps added a commit that referenced this pull request Sep 6, 2023
…#7997)

* Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates.

* Update BraveCore to v1.59.59

* Disable failing `testCompilationofResources` test.
nuo-xu pushed a commit that referenced this pull request Sep 13, 2023
…#7997)

* Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates.

* Update BraveCore to v1.59.59

* Disable failing `testCompilationofResources` test.
StephenHeaps added a commit that referenced this pull request Sep 14, 2023
…#7997)

* Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates.

* Update BraveCore to v1.59.59

* Disable failing `testCompilationofResources` test.
StephenHeaps added a commit that referenced this pull request Sep 18, 2023
…#7997)

* Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates.

* Update BraveCore to v1.59.59

* Disable failing `testCompilationofResources` test.
StephenHeaps added a commit that referenced this pull request Sep 19, 2023
* Update BraveCore to v1.59.41

* [v1.59] Fix #7866: AccountId Transaction Refactor, BraveCore v1.59.59 (#7997)

* Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates.

* Update BraveCore to v1.59.59

* Disable failing `testCompilationofResources` test.

* upgrade brave core to 1.59.84

---------

Co-authored-by: Nuo Xu <nuoxu.nx@gmail.com>
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…8077)

* Update BraveCore to v1.59.41

* [v1.59] Fix brave/brave-ios#7866: AccountId Transaction Refactor, BraveCore v1.59.59 (brave/brave-ios#7997)

* Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates.

* Update BraveCore to v1.59.59

* Disable failing `testCompilationofResources` test.

* upgrade brave core to 1.59.84

---------

Co-authored-by: Nuo Xu <nuoxu.nx@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants