Fix Twitter auth headers #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
force-pushed
the
rewards-twitter-fix-auth-headers
branch
from
a6baa6a
to
fe3aba3
Compare
emerick
requested review from
zenparsing,
jonathansampson,
marshall and
bbondy
bbondy
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #40
After testing, @jonathansampson saw that he was still receiving a 429 error in one scenario. We theorized that Twitter is sending an incorrect HTTP status for a more general error related to incorrect auth headers. We modified our function to ensure that we have appropriate auth headers when logged in or visiting Twitter as a guest.