Greaselion makes excessive calls to Twitter API #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
requested review from
zenparsing,
bbondy,
jonathansampson and
marshall
zenparsing
previously approved these changes
Jan 18, 2021
| this.maxEntries = maxEntries | ||
| } | ||
|
|
||
| public get (key: string): T | null { |
There was a problem hiding this comment.
We don't need public, since methods are public by default.
emerick
force-pushed
the
rewards-twitter-fix-excessive-api-calls
branch
from
0289262
to
8113e27
Compare
|
I just built the PR and tested in Nightly on a fresh profile, looks good. Only a single call for publisher information was made across 2 profile tests. That said, these calls do appear to fire even when the user has not yet opted in to Brave Rewards. For instance, the calls are made before the user has clicked Start using Brave Rewards in the Rewards drop-down. We should check the state of this button/opt-in when evaluating the precondition for this script to run. I'll create a new issue for tracking this. It's not a regression, so not worth blocking, IMHO.
|
zenparsing
approved these changes
Jan 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#13578
Description
Limit the number of calls we make to the Twitter API to avoid rate limiting. In addition, cache fetched publisher info in a small LRU cache to avoid making unnecessary calls in the first place.
Test Plan
https://api.twitter.com/1.1/users/show.json?screen_name={$user}more than once every 3 seconds