Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give /talk non-subscribers options to create the call anyway and to login #57

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

tackley
Copy link
Collaborator

@tackley tackley commented Nov 30, 2021

This is not totally ideal as when you login, it loses the room name you were trying to connect to, so you need to go back to slack and click the link again :( But it's better than getting stuck, and at least you can start a 1:1 room.

Re #16

Screen.Recording.2021-11-30.at.11.39.16.mov

… login

This is not totally ideal as when you login, it loses the room name you were trying to connect to, so you need to go back to slack and click the link again :(  But it's better than getting stuck, and at least you can start a 1:1 room.

Re #16
@tackley tackley marked this pull request as ready for review November 30, 2021 11:41
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tackley tackley merged commit aa44f91 into main Dec 1, 2021
@tackley tackley deleted the tackley/issue16 branch December 1, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants