Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give /talk non-subscribers options to create the call anyway and to login #16

Closed
tackley opened this issue Nov 11, 2021 · 1 comment · Fixed by #69
Closed

give /talk non-subscribers options to create the call anyway and to login #16

tackley opened this issue Nov 11, 2021 · 1 comment · Fixed by #69
Assignees
@tackley
Labels
P1

Comments

@tackley
Copy link
Collaborator

tackley commented Nov 11, 2021

brave/brave-together#258 implemented logic to try to resolve the subscriber vs non-subscriber race condition when starting a call from the slack /talk plugin. This works great if at least one person trying to join the call is already logged in as a subscriber on the browser that slack chose to open.

However, if that's not the case, it appears to get stuck in a loop and the user may have to resort to using a competitors' product. The only way out of the loop is to hack the url to remove ?create=y.

See e.g. https://bravesoftware.slack.com/archives/C01BC0K5QP7/p1636646236160700 and https://bravesoftware.slack.com/archives/C01BC0K5QP7/p1636390882144400.

When showing the "waiting for a subscriber" message we should additionally provide buttons to "create a 1:1 room" and "login".
@tackley tackley transferred this issue from another repository Nov 12, 2021
@tackley tackley added the P1 label Nov 15, 2021
tackley added a commit that referenced this issue Nov 30, 2021
@tackley
give /talk non-subscribers options to create the call anyway and to…
1f3d401 
… login

This is not totally ideal as when you login, it loses the room name you were trying to connect to, so you need to go back to slack and click the link again :(  But it's better than getting stuck, and at least you can start a 1:1 room.

Re #16
@tackley tackley mentioned this issue Nov 30, 2021
Merged
tackley added a commit that referenced this issue Dec 2, 2021
@tackley
/talk improvements: if the user logs in, try to re-open the room au…
8863a2e 
…tomatically

Re #16
@tackley tackley mentioned this issue Dec 2, 2021
Merged
tackley added a commit that referenced this issue Dec 2, 2021
@tackley
/talk improvements: if the user logs in, try to re-open the room au…
64d9c96 
…tomatically (#68)

Re #16
@tackley tackley mentioned this issue Dec 2, 2021
Merged
@tackley tackley linked a pull request Dec 2, 2021 that will close this issue
Production Release #69
Merged
@tackley
Copy link
Collaborator Author

tackley commented Dec 2, 2021

Now live in production

@tackley tackley closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tackley tackley

Labels
P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Production Release brave/brave-talk
1 participant
@tackley