This repository has been archived by the owner on May 13, 2024. It is now read-only.
Ads tipsMigrationAlert component #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
approved these changes
Nov 2, 2018
|
@ryanml there is new design for it, can you please update it? brave/brave-browser#1910 (comment) |
ryanml
force-pushed
the
feature-252
branch
3 times, most recently
from
255d09a
to
4225c44
Compare
|
@ryanml please use flex instead of inline-block, so that this scenario is handled as well
|
NejcZdovc
reviewed
Nov 2, 2018
ryanml
commented
Nov 2, 2018
| export const StyledMonthlyTips = styled<{}, 'span'>('span')` | ||
| color: #696FDC; | ||
| font-weight: 400; | ||
| display: inline-block; |
NejcZdovc
approved these changes
Nov 2, 2018
18 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #252
Related: brave/brave-browser#1910
Edit, updated design: