This repository has been archived by the owner on May 13, 2024. It is now read-only.
Implements cross-platform Backup/Recovery modal #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenn-rhim
approved these changes
Nov 14, 2018
ryanml
commented
Nov 14, 2018
| @@ -12,12 +12,13 @@ export interface Props { | |||
| readOnly?: boolean | |||
| placeholder?: string | |||
| disabled?: boolean | |||
| fieldError?: boolean | |||
There was a problem hiding this comment.
Per designs, we need to be able to highlight the text area error red in case of a problem
cc: @jenn-rhim
ryanml
commented
Nov 14, 2018
| recoveryKey: event.target.value | ||
| }) | ||
| } | ||
|
|
||
| onRestore = (key?: string) => { | ||
| key = typeof key === 'string' ? key : this.state.recoveryKey | ||
| this.setState({ |
There was a problem hiding this comment.
Per design, we want to retain the recovery key in case of a problem
cc: @jenn-rhim
ryanml
commented
Nov 14, 2018
| @@ -33,10 +37,12 @@ export interface Props { | |||
| error?: React.ReactNode | |||
| id?: string | |||
| testId?: string | |||
| funds?: string | |||
There was a problem hiding this comment.
We need to be able to produce a special warning for restore if the user has funds in their wallet.
What should be fed in this prop from assembly is a formatted string of the users BAT balance. Ex: '55 BAT'
cezaraugusto
approved these changes
Nov 14, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live storybook link: https://brave-ui-ubfmotahgl.now.sh
Preview:
(Slight differences in design vs shared components)