Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave freezes when opening tabs while a window is loading #10866

Closed
cndouglas opened this issue Sep 8, 2017 · 7 comments
Closed

Brave freezes when opening tabs while a window is loading #10866

cndouglas opened this issue Sep 8, 2017 · 7 comments

Comments

@cndouglas
Copy link

  • Did you search for similar issues before submitting this one?
    Yes.

  • Describe the issue you encountered:
    Brave freezes if you try to open tabs when a window has not loaded.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS 10.12.x.

  • Brave Version (revision SHA):
    0.18.29 (85f059d)

  • Steps to reproduce:

    1. Open Brave.
    2. While the window is still loading (while it is completely white), rapidly press Cmd+T to open new tabs.

    Or macOS-only:

    1. Open Brave.
    2. Close the window without quitting Brave
    3. Rapidly press Cmd+T to open new tabs.
  • Actual result:
    Brave freezes.

  • Expected result:
    The tabs should be opened.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Not sure.

  • Is this an issue in the currently released version?
    Yes, 0.18.29.

  • Can this issue be consistently reproduced?
    Almost all the time.

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    None.

  • Any related issues:
    Might be related to one of the freezing issues.

@cndouglas
Copy link
Author

Duplicate of #10749.

@luixxiul luixxiul added the duplicate Issue has already been reported label Sep 9, 2017
@bbondy bbondy reopened this Sep 11, 2017
@bbondy bbondy added this to the 0.19.x (Beta Channel) milestone Sep 11, 2017
@bbondy
Copy link
Member

bbondy commented Sep 11, 2017

I think this is different from #10749 so re-opening. I'm going to move this to 0.19.x and move #10749 to 0.20.x

@cndouglas
Copy link
Author

Sounds good! Please remove the duplicate tag.

@diracdeltas diracdeltas removed the duplicate Issue has already been reported label Sep 11, 2017
bbondy added a commit that referenced this issue Sep 12, 2017
Partially solves #10866
A second issue remains for #10866 where there's a race condition on the
tab index that is used.  This can exist without that though.

Browser process now registers the process right away and callbacks are registered from the window store.
It also waits until the window is ready before dispatching now.
@luixxiul luixxiul added the bug label Sep 13, 2017
@ghost ghost added the sprint/1 label Sep 13, 2017
@NumDeP
Copy link

NumDeP commented Sep 16, 2017

This issue has become too common of an occurrence and it seems its happening more regularly than before with fewer tabs than usual as well. The unresponsiveness was always an issue but the crashes weren't as regular as they have been recently, meaning before it either crashed because of a lot tabs were available and recently with fewer tabs or because the browser hadn't been refreshed in long while.

Strange thing is I can still access the contents within the page, essentially make the last viewed website function almost properly with the exception of the url bar as you can see from the gif. It seems as though I've just been locked out of the browser despite it probably working fine behind the scene.

2017-09-16_07h54_01

@bsclifton
Copy link
Member

@NumDeP good catch- this bug is crashing the UI and you can get the specific error message by pressing Shift + F8 to open the Browser developer tools and viewing the console tab (which should help us find the issue!)

If it happens again, a screenshot is appreciated 😄

@NumDeP
Copy link

NumDeP commented Sep 18, 2017

Hi @bsclifton any particular part of the console you'd like me to highlight because its literally just occurred now. All I can see is the information in this screenshot.

2017-09-18_20h25_10

bbondy added a commit that referenced this issue Sep 19, 2017
Partially solves #10866
A second issue remains for #10866 where there's a race condition on the
tab index that is used.  This can exist without that though.

Browser process now registers the process right away and callbacks are registered from the window store.
It also waits until the window is ready before dispatching now.
bbondy added a commit that referenced this issue Sep 19, 2017
Fix #10866

Changes in this PR:
- Browser process now registers the process right away for the
  dispatcher..
- Callbacks are registered from the window store.
- Waits until the window is ready before dispatching, queues up messages
  sent before this.
- No extensions.createTab will be issued before a window is ready.
bbondy added a commit that referenced this issue Sep 19, 2017
Fix #10866

Changes in this PR:
- Browser process now registers the process right away for the
  dispatcher..
- Callbacks are registered from the window store.
- Waits until the window is ready before dispatching, queues up messages
  sent before this.
- No extensions.createTab will be issued before a window is ready.
bbondy added a commit that referenced this issue Sep 19, 2017
Fix #10866

Changes in this PR:
- Browser process now registers the process right away for the
  dispatcher..
- Callbacks are registered from the window store.
- Waits until the window is ready before dispatching, queues up messages
  sent before this.
- No extensions.createTab will be issued before a window is ready.
bbondy added a commit that referenced this issue Sep 19, 2017
Fix #10866

Changes in this PR:
- Browser process now registers the process right away for the
  dispatcher..
- Callbacks are registered from the window store.
- Waits until the window is ready before dispatching, queues up messages
  sent before this.
- No extensions.createTab will be issued before a window is ready.
@bbondy bbondy closed this as completed in 912560e Sep 19, 2017
bbondy added a commit that referenced this issue Sep 19, 2017
Fix #10866

Changes in this PR:
- Browser process now registers the process right away for the
  dispatcher..
- Callbacks are registered from the window store.
- Waits until the window is ready before dispatching, queues up messages
  sent before this.
- No extensions.createTab will be issued before a window is ready.
bbondy added a commit that referenced this issue Sep 19, 2017
Fix #10866

Changes in this PR:
- Browser process now registers the process right away for the
  dispatcher..
- Callbacks are registered from the window store.
- Waits until the window is ready before dispatching, queues up messages
  sent before this.
- No extensions.createTab will be issued before a window is ready.
bbondy added a commit that referenced this issue Sep 19, 2017
bbondy added a commit that referenced this issue Sep 19, 2017
bbondy added a commit that referenced this issue Sep 19, 2017
@bsclifton
Copy link
Member

@NumDeP thanks for capturing that- seems that no error is being logged ☹️ But it looks like @bbondy has found the root cause and fixed! Stay tuned

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.