This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix dispatch issues for actions pre windowReady #10917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
approved these changes
Sep 13, 2017
bbondy
force-pushed
the
dispatch-fixes
branch
2 times, most recently
from
fe6366c
to
daa5cbe
Compare
Fix #10866 Changes in this PR: - Browser process now registers the process right away for the dispatcher.. - Callbacks are registered from the window store. - Waits until the window is ready before dispatching, queues up messages sent before this. - No extensions.createTab will be issued before a window is ready.
bbondy
force-pushed
the
dispatch-fixes
branch
from
daa5cbe
to
db1c16f
Compare
|
Cherry-picking into branches instead of merging since this PR was originally in 0.18.x but we're only putting it in 0.19.x |
|
@bbondy which branches did this get cherry-picked into? Did it ship with 0.18.x? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #10866
Submitter Checklist:
git rebase -ito squash commits (if needed).[x]Tagged reviewers and labelled the pull request as needed.Test Plan:
Reviewer Checklist:
Tests