Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

filtering for iframes not working for c62 #11621

Closed
bbondy opened this issue Oct 22, 2017 · 1 comment
Closed

filtering for iframes not working for c62 #11621

bbondy opened this issue Oct 22, 2017 · 1 comment
Assignees
@bbondy
Labels
cr62 QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.19.x Hotfix 2 (...

Comments

@bbondy
Copy link
Member

bbondy commented Oct 22, 2017 •
edited by kjozwiak
Loading

Because we are skipping if tabId is -1 in app/filtering.js

STR:

  • launch brave and load https://coinmarketcap.com/
  • wait ~10s and you should see an ad being displayed on the bottom right of the page

Example:

screen shot 2017-10-23 at 9 28 01 pm

This is not on C61 builds.
@luixxiul luixxiul added the cr62 label Oct 22, 2017
@bbondy bbondy self-assigned this Oct 22, 2017
bbondy added a commit to brave/muon that referenced this issue Oct 23, 2017
@bbondy
Fix filtering not knowing tabId
95f9cc8 
Fix brave/browser-laptop#11621
@bbondy bbondy mentioned this issue Oct 23, 2017
Merged
bbondy added a commit to brave/muon that referenced this issue Oct 23, 2017
@bbondy
Fix filtering not knowing tabId
dda8bf2 
Fix brave/browser-laptop#11621

See also:
https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/
@bbondy bbondy mentioned this issue Oct 23, 2017
Closed
bbondy added a commit to brave/muon that referenced this issue Oct 23, 2017
@bbondy
Fix filtering not knowing tabId
f2ea52e 
Fix brave/browser-laptop#11621

See also:
https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/
bbondy added a commit to brave/muon that referenced this issue Oct 23, 2017
@bbondy
Fix filtering not knowing tabId
06c7ad2 
Fix brave/browser-laptop#11621

See also:
https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/
bbondy added a commit to brave/muon that referenced this issue Oct 23, 2017
@bbondy
Fix filtering not knowing tabId
d878c6f 
Fix brave/browser-laptop#11621

See also:
https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/
bbondy added a commit to brave/muon that referenced this issue Oct 23, 2017
@bbondy
Fix filtering not knowing tabId
28bf4d4 
Fix brave/browser-laptop#11621

See also:
https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/
@bbondy
Copy link
Member Author

bbondy commented Oct 24, 2017

master: 81b7b7f
0.21.x: d3e9270
0.20.x: 83928ac
0.19.x: 4eb31ea

This was referenced Oct 25, 2017
Closed
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Oct 26, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
cr62 QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 2 (Release channel)
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @srirambv @LaurenWags