Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

afte closing a tab, tab pages quick switch to the wrong index #11902

Closed
cezaraugusto opened this issue Nov 10, 2017 · 0 comments · Fixed by #11903
Closed

afte closing a tab, tab pages quick switch to the wrong index #11902

cezaraugusto opened this issue Nov 10, 2017 · 0 comments · Fixed by #11903
Assignees
@cezaraugusto
Labels
0.19.x issue first seen in 0.19.x feature/tab-page QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x Hotfix 5 (...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Nov 10, 2017 •
edited by luixxiul
Loading

Test plan

#11903 (comment)

as reported in #11632 (comment)

11632

STR:

  1. Have 3 tab pages
  2. Set 1st tab page as active, select a tab in it
  3. Close tabs sequentially
+Result is demonstrated in the screen record. 
-Expeted to do not flash

Setting to 0.19.x hotfix 5 as it was reported in the prior version. cc @brave/release-team please push back as needed.
@cezaraugusto cezaraugusto added 0.19.x issue first seen in 0.19.x feature/tab-page labels Nov 10, 2017
@cezaraugusto cezaraugusto self-assigned this Nov 10, 2017
@cezaraugusto cezaraugusto mentioned this issue Nov 10, 2017
Closed
cezaraugusto added a commit that referenced this issue Nov 10, 2017
@cezaraugusto
remove tab page index update from WINDOW_CLOSE_FRAME
7d60343 
fix #11902
Auditors: @bbondy
cezaraugusto added a commit that referenced this issue Nov 10, 2017
@cezaraugusto
remove tab page index update from WINDOW_CLOSE_FRAME
e8e5990 
fix #11902
Auditors: @bbondy
@cezaraugusto cezaraugusto mentioned this issue Nov 10, 2017
Merged
This was referenced Nov 15, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Nov 16, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
0.19.x issue first seen in 0.19.x feature/tab-page QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 5 (Release channel)
Development

Successfully merging a pull request may close this issue.

remove tab page index update from WINDOW_CLOSE_FRAME brave/browser-laptop
5 participants
@kjozwiak @luixxiul @cezaraugusto @srirambv @LaurenWags