Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

context-menu search items doesn't use DDG if the private tab search engine is DDG #14530

Closed
diracdeltas opened this issue Jun 23, 2018 · 2 comments
Closed

context-menu search items doesn't use DDG if the private tab search engine is DDG #14530

diracdeltas opened this issue Jun 23, 2018 · 2 comments
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/not-blocking release-notes/include
Milestone
0.23.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 23, 2018 •
edited by bsclifton
Loading

Repro'ed on current release (0.22.x):

Test plan

  1. open a private tab and turn on duckduckgo for private tabs
  2. copy some text
  3. in the private tab, right-click on the urlbar and hit 'paste and go'
  4. it searches using google not ddg
  5. open another private tab, right-click some text and select 'Search for ...'
  6. it searches using google not ddg

expected: it searches using duckduckgo in both cases
@diracdeltas diracdeltas mentioned this issue Jun 23, 2018
Closed
@diracdeltas diracdeltas changed the title 'paste and go' doesn't use DDG if the private tab search engine is DDG context-menu search items doesn't use DDG if the private tab search engine is DDG Jun 23, 2018
@diracdeltas diracdeltas self-assigned this Jun 23, 2018
@diracdeltas diracdeltas added this to the 0.23.x (Beta Channel) milestone Jun 23, 2018
diracdeltas added a commit that referenced this issue Jun 23, 2018
@diracdeltas
Fix context menu search engine in private/tor tabs
a686b53 
Test Plan:
follow test plan from
#14530 and check that
duckduckgo is used in private/tor tabs if the "Use DuckDuckGo by default
for search in private/tor tabs" options are checked in
about:preferences#search. If not, it should use Google.
@diracdeltas diracdeltas mentioned this issue Jun 23, 2018
Merged
10 tasks
bsclifton pushed a commit that referenced this issue Jun 23, 2018
@diracdeltas @bsclifton
Fix context menu search engine in private/tor tabs
2325c91 
Test Plan:
follow test plan from
#14530 and check that
duckduckgo is used in private/tor tabs if the "Use DuckDuckGo by default
for search in private/tor tabs" options are checked in
about:preferences#search. If not, it should use Google.
@bsclifton
Copy link
Member

Fixed with #14531

@eljuno eljuno mentioned this issue Jun 23, 2018
Closed
This was referenced Jun 25, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Jun 25, 2018 •
edited by GeetaSarvadnya
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Windows 10 x64
• 0.23.16 2042c45
• Muon 7.1.1
• libchromiumcontent: 67.0.3396.87

bsclifton pushed a commit that referenced this issue Jun 25, 2018
@diracdeltas @bsclifton
Fix context menu search engine in private/tor tabs
80eb88c 
Test Plan:
follow test plan from
#14530 and check that
duckduckgo is used in private/tor tabs if the "Use DuckDuckGo by default
for search in private/tor tabs" options are checked in
about:preferences#search. If not, it should use Google.
bsclifton pushed a commit that referenced this issue Jun 26, 2018
@diracdeltas @bsclifton
Fix context menu search engine in private/tor tabs
22eff4e 
Test Plan:
follow test plan from
#14530 and check that
duckduckgo is used in private/tor tabs if the "Use DuckDuckGo by default
for search in private/tor tabs" options are checked in
about:preferences#search. If not, it should use Google.
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@diracdeltas @bsclifton
Fix context menu search engine in private/tor tabs
d554ab7 
Test Plan:
follow test plan from
#14530 and check that
duckduckgo is used in private/tor tabs if the "Use DuckDuckGo by default
for search in private/tor tabs" options are checked in
about:preferences#search. If not, it should use Google.
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/not-blocking release-notes/include
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
5 participants
@diracdeltas @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya