Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Opening local files in brave opens about:blank #15134

Closed
jumde opened this issue Sep 1, 2018 · 5 comments
Closed

Opening local files in brave opens about:blank #15134

jumde opened this issue Sep 1, 2018 · 5 comments
Assignees
@diracdeltas
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.24.0 - Chromium...

Comments

@jumde
Copy link
Contributor

jumde commented Sep 1, 2018 •
edited by bsclifton
Loading

Test plan

See #15204

Description

Double-click on html files opens about:blank instead of html files in brave.

From: https://www.reddit.com/r/brave_browser/comments/9bz11l/issue_opening_html_files/

Steps to Reproduce

  1. Double click on an html file

Actual result:
Opens about:blank

Expected result:
Should render the html file

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.23.105 
V8: 6.8.275.24 
rev: 9a46f8f5cb22a9daf2af21989aed25911aa6f839 
Muon: 8.0.9 
OS Release: 17.7.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 68.0.3440.84

Reproducible on current live release:
Yes

Additional Information

None
@jumde jumde added the bug label Sep 1, 2018
@bsclifton bsclifton added this to the 0.23.x Release 6 milestone Sep 1, 2018
@sjimw
Copy link

sjimw commented Sep 5, 2018

FYI, I use a local page as my home page and now when I start Brave it displays "about:blank". However, when I click on the "Open Homepage" button it does display my local page correctly. This problem began only after updating to Brave version 0.23.105.

@TimSoethout
Copy link

Also on 0.23.105 on OSX.
It's not perfect but my workaround is to copy/paste the file path in the address bar until it is solved.

@theunbound
Copy link

theunbound commented Sep 5, 2018 •
edited
Loading

Also on Windows.

about:brave info:

Brave: 0.23.105 
V8: 6.8.275.24 
rev: 9a46f8f5cb22a9daf2af21989aed25911aa6f839 
Muon: 8.0.9 
OS Release: 10.0.17751 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 68.0.3440.84

@diracdeltas
Copy link
Member

probably caused by this security fix: #14973

i considered the case where someone opens HTML files by clicking 'open file' in brave but not the case where they click on HTML files and have Brave set as the file type handler

@bsclifton bsclifton mentioned this issue Sep 12, 2018
Merged
10 tasks
@diracdeltas diracdeltas self-assigned this Sep 13, 2018
@bsclifton bsclifton mentioned this issue Sep 15, 2018
Closed
diracdeltas added a commit that referenced this issue Sep 17, 2018
@diracdeltas
Block privileged URL loads in context menu only
df790e9 
Partial revert of #14973.

Fix #15134
Fix #15203

Test Plan:
1. Repeat test plan in
   #14973 and verify it
   still passes.
2. Drag and drop an HTML or image file into Brave and verify that it
   opens
3. With Brave set to the default browser, double click an HTML file and
   verifies that it opens correctly.
@diracdeltas diracdeltas mentioned this issue Sep 17, 2018
Merged
10 tasks
This was referenced Sep 18, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Sep 18, 2018 •
edited by kjozwiak
Loading

Verified with macOS 10.12.6 using

  • 0.23.207 281de88
  • Muon 8.1.6
  • libchromiumcontent 69.0.3497.100

Verified with macOS 10.13.6 using the following build:

  • 0.23.207 281de88
  • muon: 8.1.6
  • libchromiumcontent: 69.0.3497.100

Verified on Ubuntu 17.10 x64

  • 0.23.207 281de88
  • Muon 8.1.6
  • libchromiumcontent 69.0.3497.100

Verified with Win 10 x64 using the following build:

  • 0.23.207 281de88
  • muon: 8.1.6
  • libchromiumcontent: 69.0.3497.100

However, DnD doesn't seem to be working under Win 10 & Linux. Created #15208.

@kjozwiak kjozwiak mentioned this issue Sep 19, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.24.0 - Chromium 69 (Release Channel)
Development

No branches or pull requests
9 participants
@diracdeltas @TimSoethout @jumde @kjozwiak @bsclifton @theunbound @LaurenWags @btlechowski @sjimw