Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark name of a file does not appear in the autocomplete list #2655

Closed
luixxiul opened this issue Jul 22, 2016 · 4 comments
Closed

Bookmark name of a file does not appear in the autocomplete list #2655

luixxiul opened this issue Jul 22, 2016 · 4 comments
Assignees
@NejcZdovc
Labels
feature/autocomplete feature/bookmarks feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 22, 2016 •
edited
Loading

Test plan

#10136 (comment)

Describe the issue you encountered: If you bookmark a URL to a file and set a title to the bookmark, only the URL is displayed in the autocomplete list.

Expected behavior: The title also should be displayed.
@luixxiul
Copy link
Contributor Author

I noticed that it's not related with the file type. Here's an example. STR unknown.
screenshot 2016-07-22 13 25 20

@bbondy
Copy link
Member

bbondy commented Jul 22, 2016

it is just like that when the site that was added has no title to display from a <title> element. Is there a better thing to display in that case? Maybe for a filename with a file:// with a file extension should show the filename? cc @bradleyrichter

@NejcZdovc
Copy link
Contributor

@luixxiul is this still a problem? can you please re-test it?

@luixxiul
Copy link
Contributor Author

luixxiul commented Jul 23, 2017 •
edited
Loading

It is not fixed yet.

clipboard01

clipboard01

@NejcZdovc NejcZdovc self-assigned this Jul 23, 2017
@NejcZdovc NejcZdovc added this to the 0.20.x (Nightly Channel) milestone Jul 23, 2017
This was referenced Jul 23, 2017
Closed
Merged
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 4, 2017
NejcZdovc added a commit that referenced this issue Aug 4, 2017
@NejcZdovc
Splits sites object in the app state
c2fd650 
Resolves #1646
Resolves #1856
Resolves #2655
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5072
Resolves #5699
Resolves #5382
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc @dfperry5
Splits sites object in the app state
33861b7 
Resolves brave#1646
Resolves brave#1856
Resolves brave#2655
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5072
Resolves brave#5699
Resolves brave#5382
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/autocomplete feature/bookmarks feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
6 participants
@bbondy @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags