Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Width of top border should be wider to make it easy to resize window #4782

Closed
luixxiul opened this issue Oct 14, 2016 · 25 comments
Closed

Width of top border should be wider to make it easy to resize window #4782

luixxiul opened this issue Oct 14, 2016 · 25 comments
Labels
feature/titlebar fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. OS/Windows windows-important wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 14, 2016

Describe the issue you encountered: the width of the top edge of the window is so narrow (1 or 2px?) that it is hard to grab it and resize the window.

Expected behavior: The width should be wider.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.4
  • Any related issues:
@luixxiul
Copy link
Contributor Author

@bsclifton would you please take this?

@bsclifton
Copy link
Member

@luixxiul can you show me an example of this? Not 100% clear what you mean. Is it hard to get the cursor to show as the resize cursor?

@luixxiul
Copy link
Contributor Author

@bsclifton yes it is, while the other borders are easy to grab, the top border is hard to do so. Here is an example:

border

border

Do the gifs make it clear?

@bsclifton
Copy link
Member

This one is definitely not an easy one. The reason being is that it has to do with drag area. Changing this behavior will more often than not cause a regression.

I'm going to un-assign a milestone; let's work with @bradleyrichter or @bbondy if we want to reassign it into a milestone

@bsclifton bsclifton removed this from the 0.12.9dev milestone Nov 8, 2016
@bradleyrichter
Copy link
Contributor

if you add one pixel, it will be a 2x improvement. ; )

@luixxiul
Copy link
Contributor Author

https://linkbubble.zendesk.com/agent/tickets/6980

I figured out why it is so hard to resize a Brave window! You have a 1 pixel handle to hit the activate cursor. How about 4 as what appears microsoft Excel or Word use? The are easier to use.

@bsclifton
Copy link
Member

+1 per #6333

Sometimes its difficult to resize window from the top left corner. The other sides its easy to resize. Sometimes the resize pointer changes and instead of resizing the window it just moves the browser window. (Intermittent issue)

@privatzee
Copy link
Contributor

privatzee commented Dec 22, 2016

I've been using Brave less and less because of this, as the irritation factor accumulates. It wouldn't be so bad if browser resizing would stick.

[Edit: I just only noticed that resizing does now stick - I guess it's been a while since I used Brave. So now I can resize via the bottom and the top problem can be mostly avoided.]

@bsclifton
Copy link
Member

bsclifton commented Dec 22, 2016

@privatzee sorry to hear ☹️ I know the top is sensitive. Let me elaborate:

The challenge there is that Windows requires a hit-test in order for the behavior to change. The cursor moving causes a hit test to be done. This checks the area the mouse is over:

  • if near the edge, returns "this area is resizable"
  • if it's draggable, it returns "this is a caption area"

The problem here is that the draggable property is taking precedence over the resize. In order to fix this, we'd need to dedicated 5 or so pixels around the edges to be non-draggable. Since there are already complaints about the drag area being minimal, this is a very hard compromise.

cc: @bradleyrichter for a recommendation. It would be useful to see a mock up of the top area and what is acceptable for drag / no drag.

@privatzee
Copy link
Contributor

@bsclifton Thanks for the considerate reply. How about making the top resize area bigger when the Menu Bar is being displayed (which is always true for me)? There should be plenty of room available in that case.

@bsclifton bsclifton modified the milestones: 0.13.6, 1.0.0 Feb 27, 2017
@srirambv
Copy link
Collaborator

@luixxiul
Copy link
Contributor Author

It is possible to solve the issue by adding padding-top to .top (I tried by myself), but it makes the padding area on the top of the window caption buttons unclickable.

Though there should be better solutions, it would work for a while. @bsclifton what do you think?

@luixxiul
Copy link
Contributor Author

It seems that my proposal above looks similar with Slack client.
slack

Is it OK to implement the padding-top?

@ghost
Copy link

ghost commented Aug 6, 2017

+1. Love brave but it's crazy hard to manage the window size, especially from the top or corners. Have a friend with old hands who had to switch back to Chrome because it was stressing them out trying to size the window.

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Aug 7, 2017 via email

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 7, 2017

Adding padding would only help in the window button area and not the entire top bar?

I could make it work on the entire top bar.

@luixxiul
Copy link
Contributor Author

It looks like that lately the Slack client on Windows 10 also suffers the same issue:

slack

@luixxiul luixxiul self-assigned this Aug 15, 2017
@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017
@Alan-FGR
Copy link

Alan-FGR commented Nov 18, 2017

Related I guess:
17-11-18-83
Just installed on Win7 HP 64.
Looking for a decent alternative to the terrible Firefox 57. Brave is good but UI has some issues, also lack of 'tabs on top' and customizability is a major one for me. Default UI has too much wasted space in my opinion.

@Alan-FGR
Copy link

I think the problem there is that Win7 windows have that rounded part and Brave doesn't add the resizing thing around that... not a problem in Win10 of course.

@jonathansampson
Copy link
Collaborator

@hkps4jj
Copy link

hkps4jj commented Feb 13, 2018

Sign up for this thread: problem has not been solved in 2018 :(

@jonathansampson
Copy link
Collaborator

@hkps4jj We're working on some things that will resolve this issue. You can expect to see it resolve in the not too distant future.

@srirambv
Copy link
Collaborator

@srirambv
Copy link
Collaborator

srirambv commented Jul 5, 2018

@bsclifton bsclifton added the fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. label Jul 10, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 10, 2018
@bsclifton
Copy link
Member

Fixing this in our current Muon codebase is not trivial. I'm going to close this issue as wontfix since browser-laptop is our Muon codebase.

However, coming soon, the Muon product will be replaced with Brave Core (which forks the Chromium UI). This does fix the issue. Here's a live demo of resizing in Brave Core
top-cursor

Stay tuned for a proper fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/titlebar fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. OS/Windows windows-important wontfix
Projects
None yet
Development

No branches or pull requests

10 participants