Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

twitch main stream not showing #6872

Open
alexwykoff opened this issue Jan 26, 2017 · 10 comments
Open

twitch main stream not showing #6872

alexwykoff opened this issue Jan 26, 2017 · 10 comments

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Jan 26, 2017

Domain: https://www.twitch.tv/
Reported issue: Main video is blocked, allowing ads will then show the stream
Issue reported in: v0.13.0 rc7

@lukemulks lukemulks self-assigned this Jan 26, 2017
@lukemulks
Copy link
Collaborator

lukemulks commented Jan 26, 2017

To Do:

  • Investigate if issue is present on v0.12.15
  • Determine root cause of blocking issue.
  • Provide suggested fix to resolve.

@lukemulks lukemulks added bug needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. site-bug feature/adblock and removed bug labels Jan 26, 2017
@lukemulks
Copy link
Collaborator

To Do:

  • Investigate if issue is present on v0.12.15
    Confirmed: Issue is present in v.0.12.15

Remaining Items:

  • Determine root cause of blocking issue.
  • Provide suggested fix to resolve.

@bbondy bbondy changed the title twitch main stream not showing on 0.13.0 rc7 twitch main stream not showing Jan 26, 2017
@lukemulks
Copy link
Collaborator

To Do:

Investigate if issue is present on v0.12.15
Confirmed: Issue is present in v.0.12.15

Determine root cause of blocking issue.
Determined: Twitch.tv is using cloudfront to load a script that detects ad blocking:
https://d2lv4zbk7v5f93.cloudfront.net/esf.js

Provide suggested fix to resolve:
Proposed Fix: I was able to apply a blacklist rule for the URL above that was able to prevent the invocation, while not breaking the remaining cloudfront domain calls in the sequence.

Confirming that when I applied this blacklist/blocking rule, I was able to play the video with blocking shields up, and go from clip to clip on the homepage w/o issue.

Once I removed the rule, behavior went back to blocking the video while Shields were Up.

Blacklist rule that worked:
Protocol: https
Host: *cloudfront.net
Port: *
Path: */esf.js
Query: *

With the blacklist rule applied, this is how the traffic appeared over the wire:

URL https://d2lv4zbk7v5f93.cloudfront.net/esf.js
Status Blocked
Failure Blacklisted GET https://d2lv4zbk7v5f93.cloudfront.net/esf.js - connection dropped

Remaining Items:
If the blacklist rule that I was able to get to work could be applied as a siteHack, this should fully resolve the present issue.

@lukemulks lukemulks removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Jan 27, 2017
@lukemulks lukemulks assigned bridiver and unassigned bridiver Jan 27, 2017
@lukemulks
Copy link
Collaborator

FYI - going to migrate the fix here: https://github.com/brave/adblock-lists/blob/master/brave-unbreak.txt

Will update this issue to reflect & close when completed.

@lukemulks
Copy link
Collaborator

Migrated fix to: brave/adblock-lists#2

@bbondy bbondy added this to the 0.13.0 milestone Jan 27, 2017
bbondy added a commit to brave/adblock-lists that referenced this issue Jan 27, 2017
@bbondy bbondy reopened this Jan 27, 2017
@bbondy
Copy link
Member

bbondy commented Jan 27, 2017

It's intermittent working so not sure if same fix is applied, will leave this open for @lukemulks to check and see if the new .dat file is helping or not.

Please close brave then clear this:
mac dir:
~/Library/Application\ Support/brave/ABPFilterParserData.dat

Windows dir:
%appdata%\brave\ABPFilterParserData.dat (edited)

Then you'll be able to test it with the new dat file.

@bbondy bbondy modified the milestones: 0.13.1, 0.13.0 Jan 27, 2017
@lukemulks
Copy link
Collaborator

lukemulks commented Jan 27, 2017 via email

@bbondy
Copy link
Member

bbondy commented Jan 27, 2017

I'm not certain if the thing we blocked helped or not, maybe it is intermittent and just happened to work when that was blocked?

@lukemulks
Copy link
Collaborator

lukemulks commented Jan 27, 2017 via email

@lukemulks
Copy link
Collaborator

Definitely intermittent. Very strange. Digging in further. So far, I think the update helped, but definitely think there are more pieces involved. Will update here once I get to the bottom of it.

@bbondy bbondy removed this from the 0.13.1 milestone Jan 28, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
nightsky108 pushed a commit to nightsky108/adblock-lists that referenced this issue Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants