webview crash can make webview take over full UI

[srirambv]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Page runs in browser window when a tab has webview crash

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 7 ia32

• Brave Version (revision SHA):
  Brave 0.15.1
  rev 0598ddf

• Steps to reproduce:

  1. Visit https://github.com/brave/browser-laptop in a new tab
  2. Open http://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=4085067&tag=1 in a new tab. Wait for the page to load and crash webview
  3. Open a third tab and type github.com/br and see the browser window

• Actual result:
  Browser window loads page when a tab has webview crash

• Expected result:
  Should not do that

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  No

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:
  cc: @diracdeltas @bbondy

[diracdeltas]

It doesn't appear to be loading outside the sandbox in the screenshot; the webview is just too high up by ~20 pixels.

[alexwykoff]

@srirambv I couldn't reproduce on OS X perhaps its Windows only?

[alexwykoff]

The ieee link provided looks like a pdf in your screenshot, but commonly visiting the page does not show a pdf. Since the pdf crash has been fixed in 0.15.1 will this reproduce?

[bbondy]

I think the window renderer is still inside sandbox btw.

[alexwykoff]

@srirambv let's circle back on this during the week and see if there is more to do.

[bsclifton]

Issue renamed after discovering that #9843 is a dupe. Screenshot courtesy of @patrick99e99

I had some notes about this issue after experiencing it with 0.18.17 on macOS:

• It seems that typing into the URL bar causes the issue
• a suggestion is displayed and I think that is what is shifting the UI chrome down
• if you stop typing after you notice it, you can still see the tabs (like in the screenshot above). If you switch between tabs enough, you'll eventually get one that re-opens the URL bar
• if you keep typing, the UI chrome goes completely off the screen and the page you're visiting takes up the entire screen

[bsclifton]

+1 from @jonathansampson via #10729

[NejcZdovc]

+1 from #11038

[bbondy]

master: e1066fd
0.20.x: a2cf1b5
0.19.x: 2636521

[LaurenWags]

url in step 2 doesn't crash webview for me, is there another way to check this? cc: @kjozwiak

[kjozwiak]

STR:

• install v0.19.7 rev: c8481a9
• launch Brave and visit chrome://crash
• click the address bar so the enire URL is selected and type "f"
• once the suggestion list appears, press the down arrow key and you'll notice the issue occurring

Once you've reproduce, run the above STR with the latest build to ensure that the issue isn't ocurring.

@srirambv which test case did you use to check Win 10 x64?

[srirambv]

@kjozwiak Used chrome://crash on a new tab to crash the browser webview.